Skip to content

gh-156762: Fix tp_clear slot signature for operator.methodcaller #156769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashm-dev wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

gh-156762: Fix tp_clear slot signature for operator.methodcaller #156769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7c623b
Fix tp_clear slot signature for operator.methodcaller
ashm-dev Sep 1, 2026
482f455
Merge branch 'main' into issue-156762
ashm-dev Sep 1, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Library/2026-09-01-12-00-00.gh-issue-156762.Qk3Vt1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix undefined behaviour in :class:`operator.methodcaller`: its
:c:member:`~PyTypeObject.tp_clear` slot function returned ``void`` instead of
``int``, so the garbage collector called it through an incompatible function
type. Patched by Shamil Abdulaev.
3 changes: 2 additions & 1 deletion Modules/_operator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@ methodcaller_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
return (PyObject *)mc;
}

static void
static int
methodcaller_clear(PyObject *op)
{
methodcallerobject *mc = methodcallerobject_CAST(op);
Expand All @@ -1749,6 +1749,7 @@ methodcaller_clear(PyObject *op)
Py_CLEAR(mc->kwds);
Py_CLEAR(mc->vectorcall_args);
Py_CLEAR(mc->vectorcall_kwnames);
return 0;
}

static void
Expand Down
Loading