delete only mac format files in upgrade, not complete share directory #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete only mac format files in upgrade mode, not complete share directory.
Some mac format files/folders were bundled by mistake in the installer,
which we deleted in upgrade mode. But as an attempt to achieve this,
complete share directory was getting deleted.
So, updating it to delete only required files inside share directory.
Jira issues: DBP-1274
edb-installer issues: #270
--Manika Singhal, Tested by --Manika Singhal, Reviewed by --Sandeep Thakkar, Srinu Perabattula