Upgrade object-identity#4343
Open
maraisr wants to merge 1 commit into
Open
Conversation
|
964d85f to
6f28ac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋
object-identityauthor here.I've been putting a fair bit of work into the library lately, and I think it's worth an upgrade.
I had a look at how y'all are using it (sick use-case, nice!), and I recon the new version should be noticeably faster for those shapes, maybe up to 2x faster from what I've measured. 🚀
But the bigger improvement is correctness. Previously,
identify({ id: 1 })andidentify({ id: '1' })produced the same identity. The new version fixes that, so values now preserve their types properly while still staying tiny and dependency-free.Thanks so much for building with it. Seeing it help power GitBook genuinely makes my day. ❤️🙏