Drops object-hash in favour for the platform#4344
Open
maraisr wants to merge 1 commit into
Open
Conversation
|
maraisr
requested a deployment
to
preview-approval
GitHub Actions
Waiting
maraisr
force-pushed
the
mr/drop-object-hash
branch
from
0855203 to
7f5ff0d
Compare
maraisr
requested a deployment
to
preview-approval
GitHub Actions
Waiting
maraisr
force-pushed
the
mr/drop-object-hash
branch
from
7f5ff0d to
4666475
Compare
maraisr
requested a deployment
to
preview-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While raising #4343 I noticed that ya'll using
object-hash, and believe that there can be performance/size gains there in also usingobject-identityfor that case.Further,
object-hashhas faster/better/smaller alternatives as outlined here, so took the opportunity to reach for node builtins to create the hash, usingobject-identityas the serializer.