Improve path auto-completion - #902
Conversation
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
This looks good Keith Hill (@rkeithhill) assuming I understand what's going on. We can always add more to it later but this does fix an issue that doesn't happen in the ISE.
P.S. there is a testing opportunity here for the CreateCompletionItem method 😊
7ff85b9 to
03593cc
Compare
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
LGTM unless you wanted to add some tests to make sure the $0 shows up in the right place when it needs to 😄
|
This PR is ready to go. |
Rob Holt (rjmholt)
left a comment
Rob Holt (rjmholt)
left a comment
There was a problem hiding this comment.
This is amazing!
|
Keith Hill (@rkeithhill) I think Rob Holt (@rjmholt) and I have decided that we, personally, will not spend the time to backport this, but if you'd like to do it, we would accept it! |
|
I'll backport it. I'd really like to have this in the next update. |
* WIP: Improve path auto-completion * Add comment to address PR feedback * Address PR feedback * Add tests for path completion, do not do snippet completion on files * Fix incorrect macOS/Linxu path in completion test
3 participants
Need to determine if there are other quote scenarios where we could improve auto-completion.
Fixes PowerShell/vscode-powershell#1398