Backport: Improve path auto-completion (#902) - #916
Merged
Keith Hill (rkeithhill) merged 1 commit intoApr 10, 2019
Conversation
* WIP: Improve path auto-completion * Add comment to address PR feedback * Address PR feedback * Add tests for path completion, do not do snippet completion on files * Fix incorrect macOS/Linxu path in completion test
Keith Hill (rkeithhill)
requested review from
TylerLeonhardt and
Rob Holt (rjmholt)
April 10, 2019 05:12
Rob Holt (rjmholt)
approved these changes
Apr 10, 2019
Keith Hill (rkeithhill)
deleted the
rkeithhill/cherry-pick-fix-path-auto-completions
branch
April 10, 2019 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Improve path auto-completion
Add comment to address PR feedback
Address PR feedback
Add tests for path completion, do not do snippet completion on files
Fix incorrect macOS/Linxu path in completion test