Block Supports: Add width to dimensions supports#10470
Block Supports: Add width to dimensions supports#10470aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
3e882c8 to
dede7bc
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
left a comment
There was a problem hiding this comment.
This is testing nicely for me, and the changes to the dimensions.php file to cover multiple supported features look good.
Tested by opting the Post Title block in, and tested via global styles and at the individual block instance level:
This feature has been in Gutenberg for a while now, so this looks good to land for 7.0 in time for the beta to me 🚀
dede7bc to
df6792b
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/64200
This PR brings the changes from the following Gutenberg PRs to core:
WordPress/gutenberg#71905
Description
Adds a new
dimensions.widthblock support to facilitate the creation of new blocks such as the Icon block.See: WordPress/gutenberg#71227
Testing
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.