Block Supports: Add height to dimensions supports#10474
Block Supports: Add height to dimensions supports#10474aaronrobertshaw wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
fa96f64 to
241e48e
Compare
andrewserong
left a comment
There was a problem hiding this comment.
The PR description notes that this builds on top of #10470 (and width support) and is due to be merged after that one lands. That PR is already looking good to me, so I've given this a test, too, and it's all working nicely for me just as in Gutenberg. I tried out opting the Site Title block in to the height support and gave it a height and background color, with it working nicely in global styles and at the individual block instance level:
LGTM 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tests/phpunit/tests/block-supports/wpApplyDimensionsSupport.php
Outdated
Show resolved
Hide resolved
241e48e to
7f0f17f
Compare
Warning
This PR depends on #10470 and should be rebased and merged after it.
Trac ticket: https://core.trac.wordpress.org/ticket/64202
This PR brings the changes from the following Gutenberg PR to core:
WordPress/gutenberg#71914
Description
Adds a new dimensions.height block support to facilitate the creation of new blocks such as the Icon block.
See: WordPress/gutenberg#71227
Testing