Skip to content

Block Supports: Add height to dimensions supports#10474

Closed
aaronrobertshaw wants to merge 3 commits intoWordPress:trunkfrom
aaronrobertshaw:add/height-to-dimensions-supports
Closed

Block Supports: Add height to dimensions supports#10474
aaronrobertshaw wants to merge 3 commits intoWordPress:trunkfrom
aaronrobertshaw:add/height-to-dimensions-supports

Conversation

@aaronrobertshaw
Copy link

@aaronrobertshaw aaronrobertshaw commented Nov 6, 2025

Warning

This PR depends on #10470 and should be rebased and merged after it.

Trac ticket: https://core.trac.wordpress.org/ticket/64202

This PR brings the changes from the following Gutenberg PR to core:

WordPress/gutenberg#71914

Description

Adds a new dimensions.height block support to facilitate the creation of new blocks such as the Icon block.

See: WordPress/gutenberg#71227

Testing

  1. Adopt height block support for a dynamic block e.g. Cover via its block.json file
  2. Add a height value for the chosen test block in your theme.json file
  3. Create a post with the test block type
  4. Confirm the global style is applied to your test block
@aaronrobertshaw aaronrobertshaw self-assigned this Nov 6, 2025
@aaronrobertshaw aaronrobertshaw added enhancement php Pull requests that update php code labels Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description notes that this builds on top of #10470 (and width support) and is due to be merged after that one lands. That PR is already looking good to me, so I've given this a test, too, and it's all working nicely for me just as in Gutenberg. I tried out opting the Site Title block in to the height support and gave it a height and background color, with it working nicely in global styles and at the individual block instance level:

Image

LGTM 👍

@ramonjd ramonjd marked this pull request as ready for review February 12, 2026 05:15
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, ramonopoly, andrewserong.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd force-pushed the add/height-to-dimensions-supports branch from 241e48e to 7f0f17f Compare February 12, 2026 05:19
@ramonjd
Copy link
Member

ramonjd commented Feb 12, 2026

Committed in r61620 and 3fe3acf

@ramonjd ramonjd closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement php Pull requests that update php code

3 participants