Add optional span param to end_span#1039
Merged
estolfo merged 1 commit intoelastic:masterfrom Jul 30, 2021
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
03a8dd4 to
ed70de3
Compare
mikker
approved these changes
Jul 9, 2021
Contributor
mikker
left a comment
There was a problem hiding this comment.
This is wonderful! Great addition. I don't remember anyone else using the agent with EventMachine so keep the fixes and additions coming as you encounter them ❤️
Contributor
|
jenkins, run the tests |
ed70de3 to
deea9c1
Compare
deea9c1 to
cbd8b40
Compare
Contributor
|
jenkins, run the tests |
Contributor
|
Thanks @matheussilvasantos! |
v1v
added a commit
to v1v/apm-agent-ruby
that referenced
this pull request
Sep 22, 2021
…thub-commands * upstream/master: (177 commits) synchronize json schema specs synchronize json schema specs synchronize json schema specs Update exit span definition (elastic#1154) test: synchronizing json specs Handle NaN in metrics (elastic#1157) Use Socket.gethostname instead (elastic#1155) test: synchronizing json specs synchronize json schema specs Debug instrumenter test (elastic#1146) test: synchronizing json specs v4.4.0 Disable instrumenter/metrics spec for now (elastic#1048) Fix CpuMem metrics on Alpine (elastic#1057) Fix and update changelog Add config option log_ecs_formatting (elastic#1053) ES Spy: Fake out verification for 7.14+ (elastic#1054) synchronize json schema specs Add optional span param to end_span (elastic#1039) Filter Jenkins branches (elastic#1046) ...
estolfo
pushed a commit
that referenced
this pull request
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Add optional span param to end_span
Why is it important?
When using the gem in asynchronous systems, multiple spans will be created in parallel, and they aren't going to finish in the same order they were created. Therefore, to have spans with the correct duration, we need to pass the span we want to finish - in this case, it's the developer responsibility to hold the span created and pass it to
end_span.Usage example:
Checklist
.rubocop.yml)(I'm not sure on this one)