Use Socket.gethostname instead#1155
Merged
estolfo merged 6 commits intoelastic:masterfrom Sep 7, 2021
Merged
Conversation
mikker
reviewed
Sep 1, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mikker
reviewed
Sep 6, 2021
mikker
approved these changes
Sep 7, 2021
v1v
added a commit
to v1v/apm-agent-ruby
that referenced
this pull request
Sep 22, 2021
…thub-commands * upstream/master: (177 commits) synchronize json schema specs synchronize json schema specs synchronize json schema specs Update exit span definition (elastic#1154) test: synchronizing json specs Handle NaN in metrics (elastic#1157) Use Socket.gethostname instead (elastic#1155) test: synchronizing json specs synchronize json schema specs Debug instrumenter test (elastic#1146) test: synchronizing json specs v4.4.0 Disable instrumenter/metrics spec for now (elastic#1048) Fix CpuMem metrics on Alpine (elastic#1057) Fix and update changelog Add config option log_ecs_formatting (elastic#1053) ES Spy: Fake out verification for 7.14+ (elastic#1054) synchronize json schema specs Add optional span param to end_span (elastic#1039) Filter Jenkins branches (elastic#1046) ...
estolfo
added a commit
that referenced
this pull request
Mar 2, 2023
* Use Socket.gethostname instead * Add error handling to detect_hostname * Don't add hostname at all if it can't be detected * Make sure to return the hash * Update tests * Update test description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1151
Thanks @kovyrin