Skip to content

x-pack/filebeat/input/cel: add evaluation state dump debugging feature#41335

Merged
efd6 merged 3 commits intoelastic:mainfrom
efd6:cel_fail_dump
Dec 3, 2024
Merged

x-pack/filebeat/input/cel: add evaluation state dump debugging feature#41335
efd6 merged 3 commits intoelastic:mainfrom
efd6:cel_fail_dump

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Oct 20, 2024

Proposed commit message

This allows a program to conditionally dump a complete set of evaluation states from a program in the case that it fails, allowing a trace of execution leading to the failure.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Oct 20, 2024
@efd6 efd6 self-assigned this Oct 20, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 20, 2024
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 20, 2024
@efd6 efd6 marked this pull request as ready for review October 21, 2024 04:40
@efd6 efd6 requested review from a team as code owners October 21, 2024 04:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 marked this pull request as draft October 21, 2024 04:41
@efd6 efd6 force-pushed the cel_fail_dump branch 2 times, most recently from 0cc13b6 to 5657ced Compare November 21, 2024 05:23
@efd6 efd6 marked this pull request as ready for review November 21, 2024 08:04
This allows a program to conditionally dump a complete set of evaluation states
from a program in the case that it fails, allowing a trace of execution leading
to the failure.
@efd6 efd6 removed the request for review from a team November 21, 2024 20:04
kcreddy
kcreddy previously approved these changes Dec 2, 2024
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarification. LGTM 👍🏼

@efd6 efd6 dismissed kcreddy’s stale review December 2, 2024 21:34

outdated: significant changes

@efd6 efd6 requested a review from kcreddy December 2, 2024 21:34
@efd6 efd6 merged commit 0631d8b into elastic:main Dec 3, 2024
mergify bot pushed a commit that referenced this pull request Dec 3, 2024
#41335)

This allows a program to conditionally dump a complete set of evaluation states
from a program in the case that it fails, allowing a trace of execution leading
to the failure.

(cherry picked from commit 0631d8b)
efd6 added a commit that referenced this pull request Dec 3, 2024
#41335) (#41859)

This allows a program to conditionally dump a complete set of evaluation states
from a program in the case that it fails, allowing a trace of execution leading
to the failure.

(cherry picked from commit 0631d8b)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team

3 participants