Skip to content

Add debug logging statements to auditbeat system/socket metricset #41571

Merged
fearful-symmetry merged 4 commits intoelastic:mainfrom
fearful-symmetry:socket-logs
Nov 21, 2024
Merged

Add debug logging statements to auditbeat system/socket metricset #41571
fearful-symmetry merged 4 commits intoelastic:mainfrom
fearful-symmetry:socket-logs

Conversation

@fearful-symmetry
Copy link
Contributor

Proposed commit message

This seems a little needless, but last time I had to fix the system/socket module it took forever. The code is old, complicated, and few people seem to actually understand it. This adds a handful of debug-level statements to the control flow, so if/when we run into problems with this again, we can tell someone to enable debug logging, and hopefully shorten the debugging process.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
@fearful-symmetry fearful-symmetry added the Team:Security-Linux Platform Linux Platform Team in Security Solution label Nov 8, 2024
@fearful-symmetry fearful-symmetry self-assigned this Nov 8, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner November 8, 2024 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 8, 2024
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 8, 2024
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b socket-logs upstream/socket-logs
git merge upstream/main
git push upstream socket-logs
@fearful-symmetry fearful-symmetry merged commit d31f1e6 into elastic:main Nov 21, 2024
mergify bot pushed a commit that referenced this pull request Nov 21, 2024
…1571)

* add a few log statements

* add debug log statements to system/socket

* add changelog

(cherry picked from commit d31f1e6)
fearful-symmetry added a commit that referenced this pull request Dec 6, 2024
…1571) (#41742)

* add a few log statements

* add debug log statements to system/socket

* add changelog

(cherry picked from commit d31f1e6)

Co-authored-by: Alex K. <8418476+fearful-symmetry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Security-Linux Platform Linux Platform Team in Security Solution

4 participants