Skip to content

[8.x](backport #41571) Add debug logging statements to auditbeat system/socket metricset #41742

Merged
fearful-symmetry merged 3 commits into8.xfrom
mergify/bp/8.x/pr-41571
Dec 6, 2024
Merged

[8.x](backport #41571) Add debug logging statements to auditbeat system/socket metricset #41742
fearful-symmetry merged 3 commits into8.xfrom
mergify/bp/8.x/pr-41571

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024 •
edited by zube bot
Loading

Proposed commit message

This seems a little needless, but last time I had to fix the system/socket module it took forever. The code is old, complicated, and few people seem to actually understand it. This adds a handful of debug-level statements to the control flow, so if/when we run into problems with this again, we can tell someone to enable debug logging, and hopefully shorten the debugging process.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
This is an automatic backport of pull request #41571 done by [Mergify](https://mergify.com).
@fearful-symmetry @mergify
Add debug logging statements to auditbeat system/socket metricset (#4…
dad9d7d 
…1571)

* add a few log statements

* add debug log statements to system/socket

* add changelog

(cherry picked from commit d31f1e6)
@mergify mergify bot added the backport label Nov 21, 2024
@mergify mergify bot requested a review from a team as a code owner November 21, 2024 20:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 21, 2024
@botelastic
Copy link

botelastic bot commented Nov 21, 2024

This pull request doesn't have a Team:<team> label.
@mergify
Copy link
Contributor Author

mergify bot commented Nov 25, 2024

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏
Tacklebox
Tacklebox approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Tacklebox Tacklebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/forking/forked
Otherwise lgtm :)
@mergify
Copy link
Contributor Author

mergify bot commented Dec 2, 2024

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏
@fearful-symmetry fearful-symmetry merged commit 85e0ed6 into 8.x Dec 6, 2024
@fearful-symmetry fearful-symmetry deleted the mergify/bp/8.x/pr-41571 branch December 6, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

3 participants

@Tacklebox @nicholasberlin @fearful-symmetry