[Draft] x-pack/filebeat/input/{cel,httpjson}: fix handling of ADC metadata server credentials#44351
[Draft] x-pack/filebeat/input/{cel,httpjson}: fix handling of ADC metadata server credentials#44351navnit-elastic wants to merge 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
b61be4f to
0bde817
Compare
|
@navnit-elastic, we should always split PR's for different inputs even if the change is relatively similar. We can cross reference the PR's but we should not club together. |
| return nil, fmt.Errorf("oauth2 client: error loading credentials: %w", err) | ||
| var creds *google.Credentials | ||
| var err error | ||
| if o.GoogleCredentialsJSON != nil { |
There was a problem hiding this comment.
We also need to check for empty string here. If it's empty then move to ADC flow
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Agreed, I'll split this into two PRs. |
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs