Skip to content

x-pack/filebeat/input/cel: fix handling of ADC metadata server credentials#44571

Merged
efd6 merged 3 commits intoelastic:mainfrom
navnit-elastic:44349-cel
Jun 1, 2025
Merged

x-pack/filebeat/input/cel: fix handling of ADC metadata server credentials#44571
efd6 merged 3 commits intoelastic:mainfrom
navnit-elastic:44349-cel

Conversation

@navnit-elastic
Copy link
Contributor

@navnit-elastic navnit-elastic commented May 30, 2025

Proposed commit message

x-pack/filebeat/input/cel: fix handling of ADC metadata server credentials

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@navnit-elastic navnit-elastic self-assigned this May 30, 2025
@navnit-elastic navnit-elastic added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch labels May 30, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 30, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@navnit-elastic navnit-elastic marked this pull request as ready for review May 30, 2025 05:59
@navnit-elastic navnit-elastic requested a review from a team as a code owner May 30, 2025 05:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replay of #44436 but for CEL. LGTM

@ShourieG
Copy link
Contributor

/test

@efd6 efd6 merged commit 33e468b into elastic:main Jun 1, 2025
33 checks passed
mergify bot pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)
mergify bot pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)
mergify bot pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)
mergify bot pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)
efd6 pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571) (#44589)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)

Co-authored-by: navnit-elastic <navnit.chauhan@elastic.co>
efd6 pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571) (#44590)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)

Co-authored-by: navnit-elastic <navnit.chauhan@elastic.co>
efd6 pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571) (#44591)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)

Co-authored-by: navnit-elastic <navnit.chauhan@elastic.co>
efd6 pushed a commit that referenced this pull request Jun 1, 2025
…tials (#44571) (#44592)

CEL input do not handle ADC metadata server credentials correctly.
Currently they expect a JSON key in ADC (Application Default
Credentials) which is not present when Filebeat is running on Google
Cloud Platform, as described in Google's SDK[1].

[1] https://pkg.go.dev/golang.org/x/oauth2/google#Credentials

(cherry picked from commit 33e468b)

Co-authored-by: navnit-elastic <navnit.chauhan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team

4 participants