[Metricbeat] [SQL] Remove connection string from error message

[mykola-elastic]

Proposed commit message

See title.

Use cases

This PR handles specifically the case when the mssql driver is used and the port number supplied is wrong, for example, 4xf. In this case the underlying library exposes the password (the whole connection string) in the error message and we get something like this in the logs:

[elastic_agent][warn] Unit state changed sql/metrics-default-sql/metrics-sql-1ff7729a-ac72-45c3-a643-dbd3bc24f4aa (HEALTHY->DEGRADED): Error fetching data for metricset sql.query: cannot open connection: testing connection: parse "sqlserver://SA:1234_asdf@host.docker.internal:4xf": invalid port ":4xf" after host

After this fix the string gets replaced by (redacted), like this:

[elastic_agent][warn] Unit state changed sql/metrics-default-sql/metrics-sql-1ff7729a-ac72-45c3-a643-dbd3bc24f4aa (HEALTHY->DEGRADED): Error fetching data for metricset sql.query: cannot open connection: testing connection: parse "(redacted)": invalid port ":4xf" after host

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Related issues

• Relates https://github.com/elastic/obs-integration-team/issues/304
• Relates [SQL Input] Support for masking passwords in hosts field integrations#9379
• Relates https://github.com/elastic/sdh-beats/issues/4560

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mykola-elastic? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[ishleenk17]

Looks good!

[github-actions]

@Mergifyio backport 8.17 8.18 8.19 9.0

[mergify]

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details

• #44634 [8.17](backport #44577) [Metricbeat] [SQL] Remove connection string from error message has been created for branch 8.17
• #44633 [8.18](backport #44577) [Metricbeat] [SQL] Remove connection string from error message has been created for branch 8.18
• #44635 [8.19](backport #44577) [Metricbeat] [SQL] Remove connection string from error message has been created for branch 8.19
• #44636 [9.0](backport #44577) [Metricbeat] [SQL] Remove connection string from error message has been created for branch 9.0