[8.19](backport #44577) [Metricbeat] [SQL] Remove connection string from error message#44635
Merged
mykola-elastic merged 2 commits into8.19from Jun 5, 2025
Merged
[8.19](backport #44577) [Metricbeat] [SQL] Remove connection string from error message#44635mykola-elastic merged 2 commits into8.19from
mykola-elastic merged 2 commits into8.19from
Conversation
(cherry picked from commit fafabad)
6 tasks
mykola-elastic
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Use cases
This PR handles specifically the case when the
mssqldriver is used and the port number supplied is wrong, for example,4xf. In this case the underlying library exposes the password (the whole connection string) in the error message and we get something like this in the logs:After this fix the string gets replaced by
(redacted), like this:Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Related issues
This is an automatic backport of pull request #44577 done by [Mergify](https://mergify.com).