Fix ML calendar event update scalability issues#136886
Merged
valeriy42 merged 23 commits intoelastic:mainfrom Nov 13, 2025
Merged
Fix ML calendar event update scalability issues#136886valeriy42 merged 23 commits intoelastic:mainfrom
valeriy42 merged 23 commits intoelastic:mainfrom
Conversation
- Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue - Use RefCountingListener for parallel calendar/filter updates - Add comprehensive logging throughout the system - Create CalendarScalabilityIT integration tests - Add helper methods to base test class Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing.
Collaborator
|
Hi @valeriy42, I've created a changelog YAML for you. |
…g to API calls and processing job updates asynchronously in the background.
…thub.com/valeriy42/elasticsearch into bugfix/limited-update-notification-queue
…e handling in JobManager to include skipped updates. Update logging to reflect skipped updates during background calendar processing.
…hods and updating job creation visibility. Enhance ScheduledEventsIT to verify asynchronous calendar updates and add a plugin for tracking UpdateProcessAction calls.
…the updated logging package. This change improves consistency and aligns with recent codebase updates.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Contributor
Author
|
@DonalEvans , @benwtrent , @davidkyle thank you for your comments. I introduced the suggested changed. Looking forward to your new feedback. |
DonalEvans
approved these changes
Nov 3, 2025
elasticsearchmachine
added
v9.1.8
v9.2.2
v8.19.8
and removed
v9.1.7
v9.2.1
v8.19.7
labels
valeriy42
added
the
cloud-deploy
Contributor
Author
|
The follow-up process optimization is captured in Issue #137872. |
Member
|
I was only concerned about the noisy logging, I shall remove my review request, if dave k says its good, its good. |
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
This was referenced Nov 13, 2025
Collaborator
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
valeriy42
added a commit
to valeriy42/elasticsearch
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 13, 2025
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing. Problem: UpdateJobProcessNotifier has a 1000-item queue and processes updates sequentially. It uses offer() on the queue, which silently drops updates when the queue is full. However, calendar/filter updates don't need ordering guarantees. Hence, JobManager.submitJobEventUpdate() can bypass the queue and avoid the bottleneck of the queue size. Another problem is the "fire-and-forget" pattern: submitJobEventUpdate() returns immediately without waiting for the update to complete. I introduce RefCountingListener to track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout. Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics. Refactor JobManager.submitJobEventUpdate() to bypass UpdateJobProcessNotifier queue Use RefCountingListener for parallel calendar/filter updates Add comprehensive logging throughout the system Create CalendarScalabilityIT integration tests Add helper methods to base test class
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 13, 2025
…-json * upstream/main: (158 commits) Cleanup files from repo root folder (elastic#138030) Implement OpenShift AI integration for chat completion, embeddings, and reranking (elastic#136624) Optimize AsyncSearchErrorTraceIT to avoid failures (elastic#137716) Removes support for null TransportService in RemoteClusterService (elastic#137939) Mute org.elasticsearch.index.mapper.DateFieldMapperTests testSortShortcuts elastic#138018 rest-api-spec: fix type of enums (elastic#137521) Update Gradle wrapper to 9.2.0 (elastic#136155) Add RCS Strong Verification Documentation (elastic#137822) Use docvalue skippers on dimension fields (elastic#137029) Introduce INDEX_SHARD_COUNT_FORMAT (elastic#137210) Mute org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT testCreatesChatCompletion_AndThenCreatesTextEmbedding elastic#138012 Fix ES|QL search context creation to use correct results type (elastic#137994) Improve Snapshot Logging (elastic#137470) Support extra output field in TOP function (elastic#135434) Remove NumericDoubleValues class (elastic#137884) [ML] Fix ML calendar event update scalability issues (elastic#136886) Task may be unregistered outside of the trace context in exceptional cases. (elastic#137865) Refine workaround for S3 repo analysis known issue (elastic#138000) Additional DEBUG logging on authc failures (elastic#137941) Cleanup index resolution (elastic#137867) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where calendar events failed to update some jobs when associated with large numbers of jobs (>1000) due to queue capacity limits and sequential processing.
Problem:
UpdateJobProcessNotifierhas a 1000-item queue and processes updates sequentially. It usesoffer()on the queue, which silently drops updates when the queue is full.However, calendar/filter updates don't need ordering guarantees. Hence,
JobManager.submitJobEventUpdate()can bypass the queue and avoid the bottleneck of the queue size.Another problem is the "fire-and-forget" pattern:
submitJobEventUpdate()returns immediately without waiting for the update to complete. I introduceRefCountingListenerto track the calendar updates. We start a background thread that updates the jobs and tracks succeeded, failed, and skipped jobs, while the request is returned immediately to prevent a timeout.Finally, if the problem with failed job updates persists, I enhanced the logging throughout the system to create a trace for future diagnostics.
Fixes #129777