Skip to content

Fix Span leak in APMTracer#137865

Merged
mosche merged 4 commits intoelastic:mainfrom
mosche:metrics/fixApmTracerSpanLeak
Nov 13, 2025
Merged

Fix Span leak in APMTracer#137865
mosche merged 4 commits intoelastic:mainfrom
mosche:metrics/fixApmTracerSpanLeak

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented Nov 11, 2025

Task may get unregistered outside of the trace context in exceptional cases.
This change makes sure we're stopping traces in these cases so we don't risk leaking spans in APMTracer.

…cases.

This change makes sure we're stopping traces in these cases so we don't risk
leaking spans in APMTracer.
@mosche mosche requested a review from a team November 11, 2025 07:24
@mosche mosche added >non-issue :Core/Infra/Metrics Metrics and metering infrastructure auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 branch:8.19 labels Nov 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche mosche merged commit 40ad7e2 into elastic:main Nov 13, 2025
34 checks passed
mosche added a commit to mosche/elasticsearch that referenced this pull request Nov 13, 2025
…cases. (elastic#137865)

This change makes sure we're stopping traces in these cases so we don't risk
leaking spans in APMTracer.
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 137865

elasticsearchmachine pushed a commit that referenced this pull request Nov 13, 2025
…cases. (#137865) (#138004)

This change makes sure we're stopping traces in these cases so we don't risk
leaking spans in APMTracer.
szybia added a commit to szybia/elasticsearch that referenced this pull request Nov 13, 2025
…-json

* upstream/main: (158 commits)
  Cleanup files from repo root folder (elastic#138030)
  Implement OpenShift AI integration for chat completion, embeddings, and reranking (elastic#136624)
  Optimize AsyncSearchErrorTraceIT to avoid failures (elastic#137716)
  Removes support for null TransportService in RemoteClusterService (elastic#137939)
  Mute org.elasticsearch.index.mapper.DateFieldMapperTests testSortShortcuts elastic#138018
  rest-api-spec: fix type of enums (elastic#137521)
  Update Gradle wrapper to 9.2.0 (elastic#136155)
  Add RCS Strong Verification Documentation (elastic#137822)
  Use docvalue skippers on dimension fields (elastic#137029)
  Introduce INDEX_SHARD_COUNT_FORMAT (elastic#137210)
  Mute org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT testCreatesChatCompletion_AndThenCreatesTextEmbedding elastic#138012
  Fix ES|QL search context creation to use correct results type (elastic#137994)
  Improve Snapshot Logging (elastic#137470)
  Support extra output field in TOP function (elastic#135434)
  Remove NumericDoubleValues class (elastic#137884)
  [ML] Fix ML calendar event update scalability issues (elastic#136886)
  Task may be unregistered outside of the trace context in exceptional cases. (elastic#137865)
  Refine workaround for S3 repo analysis known issue (elastic#138000)
  Additional DEBUG logging on authc failures (elastic#137941)
  Cleanup index resolution (elastic#137867)
  ...
@mosche mosche removed the v9.1.8 label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Metrics Metrics and metering infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v9.2.2 v9.3.0

3 participants