Binary doc values have stale value offset array if block contains all empty values#139922
Merged
parkertimmins merged 2 commits intoelastic:mainfrom Dec 23, 2025
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @parkertimmins, I've created a changelog YAML for you. |
martijnvg
approved these changes
Dec 23, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - let's also backport this to 9.3 branch?
I also verified that the AOBE no longer occurs locally.
parkertimmins
added
v9.3.1
auto-backport
parkertimmins
added a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Dec 23, 2025
… empty values (elastic#139922) If all values are empty, the offsets array isn't decoded. This causes the offsets already present in the offsets array to be used. Instead need to either clear the offset array or read the compressed offsets (which are all 0s.) As follow-up, we should not send the empty offsets at all; but this will require codec version change.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2025
… empty values (#139922) (#139959) If all values are empty, the offsets array isn't decoded. This causes the offsets already present in the offsets array to be used. Instead need to either clear the offset array or read the compressed offsets (which are all 0s.) As follow-up, we should not send the empty offsets at all; but this will require codec version change.
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 29, 2025
… empty values (elastic#139922) If all values are empty, the offsets array isn't decoded. This causes the offsets already present in the offsets array to be used. Instead need to either clear the offset array or read the compressed offsets (which are all 0s.) As follow-up, we should not send the empty offsets at all; but this will require codec version change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all values are empty, the offsets array isn't decoded. This causes the offsets already present in the offsets array to be used. Instead need to either clear the offset array or read the compressed offsets (which are all 0s.) As follow-up, we should not send the empty offsets at all; but this will require codec version change.