Skip to content

[9.3] Binary doc values have stale value offset array if block contains all empty values (#139922)#139959

Merged
elasticsearchmachine merged 1 commit intoelastic:9.3from
parkertimmins:backport/9.3/pr-139922
Dec 23, 2025
Merged

[9.3] Binary doc values have stale value offset array if block contains all empty values (#139922)#139959
elasticsearchmachine merged 1 commit intoelastic:9.3from
parkertimmins:backport/9.3/pr-139922

Conversation

@parkertimmins
Copy link
Contributor

Backports the following commits to 9.3:

… empty values (elastic#139922)

If all values are empty, the offsets array isn't decoded. This causes the offsets already present in the offsets array to be used. Instead need to either clear the offset array or read the compressed offsets (which are all 0s.) As follow-up, we should not send the empty offsets at all; but this will require codec version change.
@parkertimmins parkertimmins added :StorageEngine/Codec >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:StorageEngine labels Dec 23, 2025
@elasticsearchmachine elasticsearchmachine merged commit b69192f into elastic:9.3 Dec 23, 2025
35 checks passed
@parkertimmins parkertimmins deleted the backport/9.3/pr-139922 branch December 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :StorageEngine/Codec Team:StorageEngine v9.3.1

2 participants