Conversation
pzl
requested review from
ashokaditya,
joeypoon,
parkiino and
tomsonpl
and removed request for
parkiino and
tomsonpl
ashokaditya
approved these changes
Jan 21, 2025
Comment on lines
+512
to
+517
| "audit_unenrolled_time": { | ||
| "type": "date" | ||
| }, | ||
| "audit_unenrolled_reason": { | ||
| "type": "keyword" | ||
| }, |
Member
There was a problem hiding this comment.
I'm assuming these fields hold the same value as unenrolled_at and unenrolled_reason? I'm curious what triggers an update to values to these new fields.
Member
Author
There was a problem hiding this comment.
Not sure what went into the decision to use new fields, given those exist. But this is just mirroring the .fleet-agents mapping, since we union with that document. We just need to keep in sync with the agent mapping: https://github.com/elastic/elasticsearch/pull/111909/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds fleet agent unenrolled reason fields to support the new agent statuses added here: elastic/kibana#205815
Release Target
9.0+
Q/A
For mapping changes:
makeafter making the schema changes, and committed all changesmetadatachange, I also updated both transform destination schemas to matchFor Transform changes: