[Fleet] Show reason for agent/endpoint uninstall#205815
Merged
Supplementing merged 38 commits intoelastic:mainfrom Jan 14, 2025
Merged
[Fleet] Show reason for agent/endpoint uninstall#205815Supplementing merged 38 commits intoelastic:mainfrom
Supplementing merged 38 commits intoelastic:mainfrom
Conversation
…hing being returned other than undefined
…phaned on offline entries with that
…d labels with zero matches to clean up UI
Supplementing
added
release_note:enhancement
backport:skip
…/github.com/Supplementing/kibana into enhancement-show-reason-for-agent-uninstall
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Supplementing
added
release_note:skip
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
nchaulet
reviewed
Jan 8, 2025
...ns/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/utils/get_kuery.ts
Outdated
Show resolved
Hide resolved
nchaulet
reviewed
Jan 8, 2025
...ns/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/utils/get_kuery.ts
Outdated
Show resolved
Hide resolved
Member
|
Could we compute the status in the status runtime field here too? https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/server/services/agents/build_status_runtime_field.ts#L76 it will probably simplify that PR. |
… rather than needing to do a bunch of work with the audit_unenrolled_reason field
…/github.com/Supplementing/kibana into enhancement-show-reason-for-agent-uninstall
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
…needed de-duping process added earlier
…/github.com/Supplementing/kibana into enhancement-show-reason-for-agent-uninstall
kpollich
reviewed
Jan 9, 2025
Member
|
Took another look overall it looks good, I think adding a new status is probably worth updating our API integration tests for status with those new statuses https://github.com/elastic/kibana/blob/main/x-pack/test/fleet_api_integration/apis/agents/status.ts#L22 There is some doc for those tests https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/README.md#api-integration-tests-stateful but feel free to reach out if you need help running them. (the |
Removed random file again, forgot to remove on local and re-pushed it
Dont know how this made it back in, but removing it for hopefully the last time ��
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
nchaulet
reviewed
Jan 14, 2025
| ))} | ||
| {AGENT_STATUSES.map( | ||
| (status) => | ||
| agentStatus[status] > 0 && ( |
Member
There was a problem hiding this comment.
I am not sure we want to filter if there is no agent status, we recently changed that #191535
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
4 tasks
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Closes elastic#197731 - Using the new `audit_unenroll_reason`, added `Orphaned` and `Uninstalled` Badges to the table UI to make those entries distinct from the normal `offline` entries - Added conditional rendering on the labels at the top of the table to only show up when the matches are greater than zero - Updated `offline` counts to be distinct from the `orphaned` and `uninstalled` items in those labels - Added Orphaned and Uninstalled filters to status filter dropdown Screenshot of new:  ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks n/a ## Release Note Improves filtering & visibility of `Uninstalled` and `Orphaned` Agents in Fleet, by differentiating them from `Offline` agents. Status filters have been added for both `Uninstalled` and `Orphaned` agents. Agent `status` runtime field has been updated to return accordingly when an agent is `uninstalled` or `orphaned`. Additionally, improved UI by hiding agent labels with `0` agent matches. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #197731
audit_unenroll_reason, addedOrphanedandUninstalledBadges to the table UI to make those entries distinct from the normalofflineentriesofflinecounts to be distinct from theorphanedanduninstalleditems in those labelsScreenshot of new:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
n/a
Release Note
Improves filtering & visibility of
UninstalledandOrphanedAgents in Fleet, by differentiating them fromOfflineagents. Status filters have been added for bothUninstalledandOrphanedagents. Agentstatusruntime field has been updated to return accordingly when an agent isuninstalledororphaned. Additionally, improved UI by hiding agent labels with0agent matches.