[8.18](backport #5176) Fix download_rate as string on checkin handling#5189
Merged
michel-laterman merged 3 commits into8.18from Jul 30, 2025
Merged
[8.18](backport #5176) Fix download_rate as string on checkin handling#5189michel-laterman merged 3 commits into8.18from
michel-laterman merged 3 commits into8.18from
Conversation
Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go
Contributor
Author
|
Cherry-pick of c94d8d9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
3 tasks
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
michel-laterman
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What is the problem this PR solves?
Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's
download_rateas a string instead of float64.How does this PR solve the problem?
Fleet-server will parse the string into a float representing bps and re-marshal the metadata.
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request Fix download_rate as string on checkin handling #5176 done by Mergify.