Fix download_rate as string on checkin handling by michel-laterman · Pull Request #5176 · elastic/fleet-server

michel-laterman · 2025-07-24T16:05:14Z

What is the problem this PR solves?

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64.

How does this PR solve the problem?

Fleet-server will parse the string into a float representing bps and re-marshal the metadata.

Design Checklist

~~I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.~~
~~I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.~~
~~I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.~~

Checklist

I have commented my code, particularly in hard-to-understand areas
~~I have made corresponding changes to the documentation~~
~~I have made corresponding change to the default configuration files~~
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Closes Handle schema incompatibility with Elastic Agent <8.16 #5164

prodsecmachine · 2025-07-24T16:06:22Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

michel-laterman · 2025-07-24T19:42:23Z

Marking this back as a draft, I wasn't confident in the fix and have added an e2e test that shows it's still failing

cmacknz · 2025-07-28T14:38:02Z

Current example of this error in a support case:

Error while parsing document for index [.fleet-agents-7]: [1:3875] failed to parse field [upgrade_details.metadata.download_rate] of type [double] in document with id '1046bb63-c8aa-4ea2-8690-9bc2bd378af1'. Preview of field's value: '320.822575kBps'

michel-laterman · 2025-07-28T16:38:32Z

buildkite test this

elastic-sonarqube · 2025-07-29T18:26:53Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
42.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

blakerouse

Looks good.

Nice coverage on the tests.

github-actions · 2025-07-29T23:20:13Z

@Mergifyio backport 8.17 8.18 8.19 9.0 9.1

mergify · 2025-07-29T23:20:25Z

backport 8.17 8.18 8.19 9.0 9.1

✅ Backports have been created

Details

#5188 [8.17](backport #5176) Fix download_rate as string on checkin handling has been created for branch 8.17 but encountered conflicts
#5189 [8.18](backport #5176) Fix download_rate as string on checkin handling has been created for branch 8.18 but encountered conflicts
#5190 [8.19](backport #5176) Fix download_rate as string on checkin handling has been created for branch 8.19
#5191 [9.0](backport #5176) Fix download_rate as string on checkin handling has been created for branch 9.0 but encountered conflicts
#5192 [9.1](backport #5176) Fix download_rate as string on checkin handling has been created for branch 9.1

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9)

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9)

…#5191) * Fix download_rate as string on checkin handling (#5176) Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go * Fix merge --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

#5188) * Fix download_rate as string on checkin handling (#5176) Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go * Fix merge * Add upgrade response body for errors --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>

#5189) * Fix download_rate as string on checkin handling (#5176) Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) # Conflicts: # testing/e2e/scaffold/scaffold.go * Fix merge * Add upgrade response body for errors --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>

cmacknz · 2025-07-31T20:41:58Z

 		}
+		if err := details.Metadata.FromUpgradeMetadataDownloading(upgradeDetails); err != nil {
+			vSpan.End()
+			return fmt.Errorf("%w %s: unable to repack metadata: %w", ErrInvalidUpgradeMetadata, UpgradeDetailsStateUPGDOWNLOADING, err)


Sorry for the late review, but the root cause one layer up from this is we consider parsing upgrade details to be a fatal error and it isn't. Upgrade details are nice to have.

Failing to parse upgrade details should not be fatal to processing a checkin request #5199

#5190) * Fix download_rate as string on checkin handling (#5176) Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64. (cherry picked from commit c94d8d9) * Add upgrade response body for errors * change upgrade version --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>

Fix download_rate as string on checkin handling

27d6dd1

michel-laterman requested a review from a team as a code owner July 24, 2025 16:05

michel-laterman added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-all Automated backport with mergify to all the active branches labels Jul 24, 2025

michel-laterman requested review from michalpristas and straistaru July 24, 2025 16:05

michel-laterman commented Jul 24, 2025

View reviewed changes

Comment thread internal/pkg/api/handleCheckin.go Outdated

michel-laterman added 2 commits July 24, 2025 10:10

Fix typo in comment

de5dfa7

Add e2e test

ac37706

michel-laterman marked this pull request as draft July 24, 2025 19:42

michel-laterman added 3 commits July 24, 2025 14:45

api tests dump logs on failure

3af020e

Fix bug

c8b7276

Cleanup comments

098b6a0

michel-laterman marked this pull request as ready for review July 24, 2025 21:50

Repack UPG_FAILED metadata to strip extra attributes

79f4388

Add unit-test

a2eb82f

michel-laterman commented Jul 28, 2025

View reviewed changes

Comment thread internal/pkg/api/metadata_test.go

Merge branch 'main' into fix/download-rate-string

2dece1d

blakerouse approved these changes Jul 29, 2025

View reviewed changes

michel-laterman merged commit c94d8d9 into elastic:main Jul 29, 2025
9 checks passed

michel-laterman deleted the fix/download-rate-string branch July 29, 2025 23:20

mergify Bot mentioned this pull request Jul 29, 2025

[8.17](backport #5176) Fix download_rate as string on checkin handling #5188

Merged

3 tasks

mergify Bot mentioned this pull request Jul 29, 2025

[8.18](backport #5176) Fix download_rate as string on checkin handling #5189

Merged

3 tasks

mergify Bot mentioned this pull request Jul 29, 2025

[8.19](backport #5176) Fix download_rate as string on checkin handling #5190

Merged

3 tasks

mergify Bot mentioned this pull request Jul 29, 2025

[9.0](backport #5176) Fix download_rate as string on checkin handling #5191

Merged

3 tasks

mergify Bot mentioned this pull request Jul 29, 2025

[9.1](backport #5176) Fix download_rate as string on checkin handling #5192

Merged

3 tasks

cmacknz mentioned this pull request Jul 31, 2025

Failing to parse upgrade details should not be fatal to processing a checkin request #5199

Open

cmacknz reviewed Jul 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix download_rate as string on checkin handling#5176

Fix download_rate as string on checkin handling#5176
michel-laterman merged 9 commits intoelastic:mainfrom
michel-laterman:fix/download-rate-string

michel-laterman commented Jul 24, 2025

prodsecmachine commented Jul 24, 2025 •

edited

Loading

Uh oh!

michel-laterman commented Jul 24, 2025

cmacknz commented Jul 28, 2025

Uh oh!

michel-laterman commented Jul 28, 2025

elastic-sonarqube Bot commented Jul 29, 2025

blakerouse left a comment

Uh oh!

github-actions Bot commented Jul 29, 2025

mergify Bot commented Jul 29, 2025 •

edited

Loading

cmacknz Jul 31, 2025

Labels

4 participants

Conversation

michel-laterman commented Jul 24, 2025

What is the problem this PR solves?

How does this PR solve the problem?

Design Checklist

Checklist

Related issues

prodsecmachine commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

michel-laterman commented Jul 24, 2025

cmacknz commented Jul 28, 2025

Uh oh!

michel-laterman commented Jul 28, 2025

elastic-sonarqube Bot commented Jul 29, 2025

Quality Gate passed

blakerouse left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 29, 2025

mergify Bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

cmacknz Jul 31, 2025

Choose a reason for hiding this comment

Labels

4 participants

prodsecmachine commented Jul 24, 2025 •

edited

Loading

mergify Bot commented Jul 29, 2025 •

edited

Loading