Skip to content

[9.1](backport #5176) Fix download_rate as string on checkin handling#5192

Merged
michel-laterman merged 1 commit into9.1from
mergify/bp/9.1/pr-5176
Jul 30, 2025
Merged

[9.1](backport #5176) Fix download_rate as string on checkin handling#5192
michel-laterman merged 1 commit into9.1from
mergify/bp/9.1/pr-5176

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 29, 2025

What is the problem this PR solves?

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64.

How does this PR solve the problem?

Fleet-server will parse the string into a float representing bps and re-marshal the metadata.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Fix fleet-server to properly handle when an agent sends the upgrade downloading detail's download_rate as a string instead of float64.

(cherry picked from commit c94d8d9)
@mergify mergify Bot added the backport label Jul 29, 2025
@mergify mergify Bot requested a review from a team as a code owner July 29, 2025 23:21
@mergify mergify Bot requested review from blakerouse and michalpristas July 29, 2025 23:21
@github-actions github-actions Bot added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jul 29, 2025
@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Jul 29, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@michel-laterman michel-laterman merged commit 1fb755a into 9.1 Jul 30, 2025
9 of 10 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/9.1/pr-5176 branch July 30, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

2 participants