Skip to content

Adapt definitions of nested subfields to current Fleet implementation - #11016

Merged
jsoriano merged 2 commits into
elastic:mainfrom
jsoriano:nested-subfields
Sep 6, 2024
Merged

Adapt definitions of nested subfields to current Fleet implementation#11016
jsoriano merged 2 commits into
elastic:mainfrom
jsoriano:nested-subfields

Conversation

@jsoriano

@jsoriano jsoriano commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

Adapt definitions of subfields of nested objects so they are actually installed by Fleet. New mappings are otherwise equivalent.

These mappings were correctly defined as expected by the spec, but Fleet was only installing empty nested objects. To workaround that, subfields can be moved to have their own definitions.

Issue in Fleet is fixed in elastic/kibana#191730, but we can apply this workaround for older versions of the stack.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Install one of these packages, and check that the index templates include the mappings for the fields of the nested objects.

Related issues

@jsoriano jsoriano self-assigned this Sep 5, 2024
@jsoriano
jsoriano requested review from a team as code owners September 5, 2024 11:41
@jsoriano jsoriano added Integration:gcp Google Cloud Platform Integration:google_workspace Google Workspace Integration:github GitHub Integration:akamai Akamai Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Integration:tanium Tanium Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:jamf_protect Jamf Protect Integration:trellix_edr_cloud Trellix EDR Cloud Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Integration:falco Falco labels Sep 5, 2024
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @jsoriano

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked akamai. Looks good.

@jlind23

jlind23 commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

@lalit-satapathy @axw could we please get someone from your team reviewing this?

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed gcp package from infraobs team. Looks good!

@axw

axw commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

I only looked at gcp, and mostly rubberstamping because @ishleenk17 already looked. (Logic looks sound though.)

@jsoriano
jsoriano merged commit 0751dc1 into elastic:main Sep 6, 2024
@jsoriano
jsoriano deleted the nested-subfields branch September 6, 2024 10:02
@elasticmachine

Copy link
Copy Markdown

Package akamai - 2.25.1 containing this change is available at https://epr.elastic.co/search?package=akamai

@elasticmachine

Copy link
Copy Markdown

Package falco - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=falco

@elasticmachine

Copy link
Copy Markdown

Package gcp - 2.37.2 containing this change is available at https://epr.elastic.co/search?package=gcp

@elasticmachine

Copy link
Copy Markdown

Package github - 1.29.1 containing this change is available at https://epr.elastic.co/search?package=github

@elasticmachine

Copy link
Copy Markdown

Package google_workspace - 2.25.1 containing this change is available at https://epr.elastic.co/search?package=google_workspace

@elasticmachine

Copy link
Copy Markdown

Package jamf_protect - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=jamf_protect

@elasticmachine

Copy link
Copy Markdown

Package tanium - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=tanium

@elasticmachine

Copy link
Copy Markdown

Package trellix_edr_cloud - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=trellix_edr_cloud

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
…elastic#11016)

These mappings were correctly defined as expected by the spec, but Fleet was only
installing empty nested objects. To workaround that, subfields can be moved to have
their own definitions.

Issue in Fleet is fixed in elastic/kibana#191730, we can apply this workaround for
current versions of the stack.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
…elastic#11016)

These mappings were correctly defined as expected by the spec, but Fleet was only
installing empty nested objects. To workaround that, subfields can be moved to have
their own definitions.

Issue in Fleet is fixed in elastic/kibana#191730, we can apply this workaround for
current versions of the stack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:akamai Akamai Integration:falco Falco Integration:gcp Google Cloud Platform Integration:github GitHub Integration:google_workspace Google Workspace Integration:jamf_protect Jamf Protect Integration:tanium Tanium Integration:trellix_edr_cloud Trellix EDR Cloud Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

6 participants