[proofpoint_on_demand] Adapt definitions of nested subfields - #11031
Merged
Conversation
jsoriano
added
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @jsoriano |
|
efd6
approved these changes
Sep 8, 2024
|
Package proofpoint_on_demand - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=proofpoint_on_demand |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…#11031) Adapt definitions of subfields of nested objects so they are actually installed by Fleet. New mappings are otherwise equivalent. These mappings were correctly defined as expected by the spec, but Fleet was only installing empty nested objects. To workaround that, subfields can be moved to have their own definitions. Issue in Fleet is fixed in elastic/kibana#191730, but we can apply this workaround for older versions of the stack.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…#11031) Adapt definitions of subfields of nested objects so they are actually installed by Fleet. New mappings are otherwise equivalent. These mappings were correctly defined as expected by the spec, but Fleet was only installing empty nested objects. To workaround that, subfields can be moved to have their own definitions. Issue in Fleet is fixed in elastic/kibana#191730, but we can apply this workaround for older versions of the stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #11016 that I forgot to apply to this package.
Adapt definitions of subfields of nested objects so they are actually installed by Fleet. New mappings are otherwise equivalent.
These mappings were correctly defined as expected by the spec, but Fleet was only installing empty nested objects. To workaround that, subfields can be moved to have their own definitions.
Issue in Fleet is fixed in elastic/kibana#191730, but we can apply this workaround for older versions of the stack.