[zscaler_zia] Add support for SaaS Security Activity data stream - #18986
Conversation
Vale Linting ResultsSummary: 6 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/zscaler_zia/docs/README.md | 1376 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/zscaler_zia/docs/README.md | 1376 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/zscaler_zia/docs/README.md | 1377 | Elastic.DirectionalLanguage | Don't use directional language. Use 'earlier on this page' instead of 'noted above'. |
| packages/zscaler_zia/docs/README.md | 1378 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/zscaler_zia/docs/README.md | 1379 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/zscaler_zia/docs/README.md | 1380 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
endpoint_dlp |
2427.18 | 1751.31 | -675.87 (-27.85%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| field: event.kind | ||
| tag: set_event_kind_to_event | ||
| value: event | ||
| - append: |
There was a problem hiding this comment.
I think event.category: iam is over-broad if applied to all activity types. We should map activity.type to event.category if we know all possible values for activity.type, e.g. append file for file ops and authentication for Login.
| {{#if enable_request_tracer}} | ||
| tracer.filename: "../../logs/http_endpoint/http-request-trace-*.ndjson" | ||
| tracer.maxbackups: 5 | ||
| {{/if}} |
| type: bool | ||
| multi: false | ||
| default: false | ||
| - name: preserve_duplicate_custom_fields |
There was a problem hiding this comment.
We should not be adding it to new data streams.
There was a problem hiding this comment.
So, are you suggesting that we completely remove the preserve_duplicate_custom_fields variable?
efd6
left a comment
There was a problem hiding this comment.
LGTM after conflicts are fixed.
💚 Build Succeeded
History
|
|
Package zscaler_zia - 3.21.0 containing this change is available at https://epr.elastic.co/package/zscaler_zia/3.21.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally