[GCP] Add GCP Compute Metricset

[legoguy1000]

What does this PR do?

Adds GCP Compute Metricset

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Relates Migrate some Metricbeat modules to GCP package #490

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-12-29T21:30:53.845+0000

• Duration: 18 min 21 sec

• Commit: 32e57ee

Test stats 🧪

Test	Results
Failed	0
Passed	43
Skipped	0
Total	43

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[legoguy1000]

@endorama next one ready for your review

[legoguy1000]

@endorama Any thoughts on this one?

[elasticmachine]

Pinging @elastic/integrations (Team:Integrations)

[kaiyan-sheng]

Looks good to me! Waiting for @endorama 's review 🙂

[kaiyan-sheng]

/test

[endorama]

Sorry for the delay, I've been stuck adding tests to the billing data stream. I did a first round of review and noticed something strange with field names.

[legoguy1000]

@endorama updates pushed

[endorama]

@legoguy1000 thanks! May you please check dashboards too? It seems those still contains old values.

[legoguy1000]

@endorama Dashboards should be updated.

[endorama]

Thank you for the updates! I see tests are still failing, but wasn't able to pin point the exact issue.

[endorama]

rerunning tests in case has been a transactional issue.

/test

[legoguy1000]

@endorama It looks to be a mismatch between the sample _event.json and the defined fields for the compute dataset. The sample events from Metricbeat, https://github.com/elastic/beats/tree/master/x-pack/metricbeat/module/gcp/compute/_meta, were not updated for the new field names and as such don't match the fields.yml. Do you happen to have updated sample events that could be used?

[endorama]

@legoguy1000 I'm working on updating the sample data, thanks for the hint

[endorama]

I've been able to update the sample data and working on a PR in beats to update them.

[legoguy1000]

I've been able to update the sample data and working on a PR in beats to update them.

Cool, feel free to push that update to this branch or send it to me and I'll update it.

[endorama]

@legoguy1000 I started working on updating the sample events in beats in the linked PR, but is taking longer than expected. In any case I've been able to update the compute metricset sample events, so you may take those to update this PR, and I expect that to work. Meanwhile I'll work on updating the beats side too.

[legoguy1000]

@endorama looks like it worked.

[endorama]

Thank you! I'm merging this as is good to go, I'll open a separate PR with testing for this data stream.

@legoguy1000 next week I'll be off, so feel free to open the next PR but I won't be able to look at it before the 10th of January. Thank you for the contribution and happy new year!