Skip to content

[GCP] Convert GCP GKE metricset from lightweight - #3793

Merged
kaiyan-sheng merged 2 commits into
elastic:mainfrom
legoguy1000:490-gcp-gke
Sep 19, 2022
Merged

[GCP] Convert GCP GKE metricset from lightweight#3793
kaiyan-sheng merged 2 commits into
elastic:mainfrom
legoguy1000:490-gcp-gke

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Jul 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Convert GCP GKE metricset from lightweight

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@legoguy1000
legoguy1000 requested review from a team as code owners July 21, 2022 15:12
@elasticmachine

elasticmachine commented Jul 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T19:53:01.956+0000

  • Duration: 19 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
efd6
efd6 reviewed Jul 22, 2022
View reviewed changes
Comment thread packages/gcp/_dev/build/docs/metrics.md Outdated
Comment thread packages/gcp/_dev/build/docs/gke.md Outdated
Comment thread packages/gcp/kibana/dashboard/gcp-1ae960c0-f9f8-11eb-bc38-79936db7c106.json Outdated
@efd6

efd6 commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

/test
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
@legoguy1000 legoguy1000 changed the title [GCP] Add GCP GKE Metricset Sep 19, 2022
@legoguy1000

legoguy1000 commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng ready to merge this once #3798 is merged.
@legoguy1000

legoguy1000 commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

@kaiyan-sheng ready for test.
@kaiyan-sheng

kaiyan-sheng commented Sep 19, 2022

Copy link
Copy Markdown

/test
@elasticmachine

elasticmachine commented Sep 19, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

Package gcp 👍(5) 💚(0) 💔(0)

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Sep 19, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.516
Classes 100.0% (5/5) 💚 2.516
Methods 90.816% (89/98) 👍 0.574
Lines 95.752% (1375/1436) 👍 4.439
Conditionals 100.0% (0/0) 💚
@kaiyan-sheng
kaiyan-sheng merged commit 4ddf3b2 into elastic:main Sep 19, 2022
@legoguy1000
legoguy1000 deleted the 490-gcp-gke branch September 19, 2022 20:31
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@legoguy1000
[GCP] Convert GKE metricset from lightweight (elastic#3793)
fc477b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

5 participants

@legoguy1000 @elasticmachine @efd6 @kaiyan-sheng @endorama