Skip to content

[microsoft_sqlserver] Introduced merge results flag in performance data streams - #4561

Merged
ManojS-shetty merged 6 commits into
elastic:mainfrom
ManojS-shetty:mssql_merge_performance
Nov 9, 2022
Merged

[microsoft_sqlserver] Introduced merge results flag in performance data streams#4561
ManojS-shetty merged 6 commits into
elastic:mainfrom
ManojS-shetty:mssql_merge_performance

Conversation

@ManojS-shetty

@ManojS-shetty ManojS-shetty commented Nov 4, 2022

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR introduces merge_results flag for performance data stream, which is responsible to create a single event by combining the metrics together in a single event.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone the PR branch locally.
  • Bring up the elastic stack.
  • Add the new microsoft_sqlserver integration.
  • The MSSQL metrics should be flowing to Kibana
  • The multiple events from multiple queries should result into a single event.

Related issues
@ManojS-shetty
Introuduced merge results in performance
6f3e00f 
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/changelog.yml
	modified:   packages/microsoft_sqlserver/data_stream/performance/agent/stream/stream.yml.hbs
	modified:   packages/microsoft_sqlserver/data_stream/performance/sample_event.json
	modified:   packages/microsoft_sqlserver/docs/README.md
	modified:   packages/microsoft_sqlserver/manifest.yml
@ManojS-shetty ManojS-shetty self-assigned this Nov 4, 2022
@ManojS-shetty ManojS-shetty added 8.6 candidate Team:Service-Integrations Label for the Observability Service Integrations team labels Nov 4, 2022
@elasticmachine

elasticmachine commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-08T08:44:54.180+0000

  • Duration: 17 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown

🚀 Benchmarks report

Package microsoft_sqlserver 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 13333.33 9708.74 -3624.59 (-27.18%) 💔

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Nov 4, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.365
Classes 100.0% (2/2) 💚 2.365
Methods 93.333% (28/30) 👍 2.145
Lines 100.0% (1238/1238) 💚 8.557
Conditionals 100.0% (0/0) 💚
@ManojS-shetty
ManojS-shetty marked this pull request as ready for review November 7, 2022 03:53
@ManojS-shetty
ManojS-shetty requested review from a team as code owners November 7, 2022 03:53
efd6
efd6 reviewed Nov 7, 2022
View reviewed changes
Comment thread packages/microsoft_sqlserver/_dev/build/docs/README.md Outdated
@ManojS-shetty
Change in README file
7138a36 
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/docs/README.md
@ManojS-shetty
README updated with details link
28790cc 
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/docs/README.md
efd6
efd6 reviewed Nov 7, 2022
View reviewed changes
Comment thread packages/microsoft_sqlserver/data_stream/performance/agent/stream/stream.yml.hbs
@ManojS-shetty
ManojS-shetty merged commit c62de13 into elastic:main Nov 9, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ManojS-shetty
[microsoft_sqlserver] Introduced merge results flag in performance da…
20c3e2f 
…ta streams (elastic#4561)

* Introuduced merge results in performance
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/changelog.yml
	modified:   packages/microsoft_sqlserver/data_stream/performance/agent/stream/stream.yml.hbs
	modified:   packages/microsoft_sqlserver/data_stream/performance/sample_event.json
	modified:   packages/microsoft_sqlserver/docs/README.md
	modified:   packages/microsoft_sqlserver/manifest.yml

* Updated manifest version

* Change in README file
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/docs/README.md

* README updated with details link
	modified:   packages/microsoft_sqlserver/_dev/build/docs/README.md
	modified:   packages/microsoft_sqlserver/docs/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.6 candidate Team:Service-Integrations Label for the Observability Service Integrations team

4 participants

@ManojS-shetty @elasticmachine @lalit-satapathy @efd6