Skip to content

[microsoft_sqlserver] Introduced merge results flag in performance data streams #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManojS-shetty merged 6 commits into from
Nov 9, 2022
Merged

[microsoft_sqlserver] Introduced merge results flag in performance data streams #4561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f3e00f
Introuduced merge results in performance
ManojS-shetty Nov 4, 2022
ba15b68
Merge branch 'main' into mssql_merge_performance
ManojS-shetty Nov 4, 2022
c85c1e0
Updated manifest version
ManojS-shetty Nov 4, 2022
7138a36
Change in README file
ManojS-shetty Nov 7, 2022
28790cc
README updated with details link
ManojS-shetty Nov 7, 2022
68ea4a2
Merge branch 'main' into mssql_merge_performance
ManojS-shetty Nov 8, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/microsoft_sqlserver/_dev/build/docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ See: [View the SQL Server error log in SQL Server Management Studio](https://doc

Collects the `performance` counter metrics. Dynamic counter feature provides flexibility to collect metrics by providing the counter name as an input.

The feature `merge_results` has been introduced in 8.4 beats which create a single event by combining the metrics together in a single event. See [here](https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-module-sql.html#_example_merge_multiple_queries_to_single_event) for details.

See: [Instructions about each performance counter metrics](https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-os-performance-counters-transact-sql?view=sql-server-ver15)

### transaction_log metrics
Expand Down
3 changes: 3 additions & 0 deletions packages/microsoft_sqlserver/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# newer versions go on top
- version: "1.7.0"
changes:
- description: Merge results introuduced in performance.
type: enhancement
link: https://github.com/elastic/integrations/pull/4561
- description: Allow text encoding configuration.
type: enhancement
link: https://github.com/elastic/integrations/pull/4554
Expand Down
1 change: 1 addition & 0 deletions packages/microsoft_sqlserver/data_stream/performance/agent/stream/stream.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ hosts:
- sqlserver://{{username}}:{{password}}@{{hosts}}
period: {{period}}
raw_data.enabled: true
merge_results: true
Comment thread
efd6 marked this conversation as resolved.
# Below dynamic_counter_name handles the dynamic counter name passing it to SQL query
dynamic_counter_name: {{dynamic_counter_name}}
driver: "mssql"
Expand Down
49 changes: 34 additions & 15 deletions packages/microsoft_sqlserver/data_stream/performance/sample_event.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"@timestamp": "2022-06-08T13:35:05.558Z",
"@timestamp": "2022-11-04T12:33:59.171Z",
"agent": {
"ephemeral_id": "16ad2de8-8ba3-496f-98d1-cbe19441c168",
"id": "848cea0e-c052-49b3-983d-64e13d3b9a6f",
"ephemeral_id": "54815e19-bc14-40d2-b1e0-c16234963b52",
"id": "bd4366c7-33ba-4d56-8c63-fc6a15c98c17",
"name": "docker-fleet-agent",
"type": "metricbeat",
"version": "8.3.0"
"version": "8.5.0"
},
"cloud": {
"account": {},
Expand All @@ -31,36 +31,37 @@
"version": "8.0.0"
},
"elastic_agent": {
"id": "848cea0e-c052-49b3-983d-64e13d3b9a6f",
"snapshot": true,
"version": "8.3.0"
"id": "bd4366c7-33ba-4d56-8c63-fc6a15c98c17",
"snapshot": false,
"version": "8.5.0"
},
"event": {
"agent_id_status": "verified",
"dataset": "microsoft_sqlserver.performance",
"duration": 7151724,
"ingested": "2022-06-08T13:35:06Z",
"duration": 42729100,
"ingested": "2022-11-04T12:34:00Z",
"module": "sql"
},
"host": {
"architecture": "x86_64",
"containerized": true,
"containerized": false,
"hostname": "docker-fleet-agent",
"id": "66392b0697b84641af8006d87aeb89f1",
"ip": [
"172.18.0.4"
"172.18.0.7"
],
"mac": [
"02:42:ac:12:00:04"
"02-42-AC-12-00-07"
],
"name": "docker-fleet-agent",
"os": {
"codename": "focal",
"family": "debian",
"kernel": "5.10.16.3-microsoft-standard-WSL2",
"kernel": "5.10.104-linuxkit",
"name": "Ubuntu",
"platform": "ubuntu",
"type": "linux",
"version": "20.04.4 LTS (Focal Fossa)"
"version": "20.04.5 LTS (Focal Fossa)"
}
},
"metricset": {
Expand All @@ -69,11 +70,29 @@
},
"mssql": {
"metrics": {
"active_temp_tables": 0,
"batch_requests_per_sec": 59,
"buffer_cache_hit_ratio": 990,
"buffer_checkpoint_pages_per_sec": 105,
"buffer_database_pages": 2215,
"buffer_page_life_expectancy": 18,
"buffer_target_pages": 2408448,
"compilations_per_sec": 81,
"dynamic_counter": {
"name": "Memory Grants Pending ",
"value": 0
},
"lock_waits_per_sec": 6,
"logins_per_sec": 18,
"logouts_per_sec": 17,
"page_splits_per_sec": 9,
"re_compilations_per_sec": 0,
"transactions": 0,
"user_connections": 1
}
},
"service": {
"address": "elastic-package-service-microsoft_sqlserver-1:1433",
"address": "elastic-package-service_microsoft_sqlserver_1",
"type": "sql"
}
}
51 changes: 36 additions & 15 deletions packages/microsoft_sqlserver/docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ See: [View the SQL Server error log in SQL Server Management Studio](https://doc

Collects the `performance` counter metrics. Dynamic counter feature provides flexibility to collect metrics by providing the counter name as an input.

The feature `merge_results` has been introduced in 8.4 beats which create a single event by combining the metrics together in a single event. See [here](https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-module-sql.html#_example_merge_multiple_queries_to_single_event) for details.

See: [Instructions about each performance counter metrics](https://docs.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-os-performance-counters-transact-sql?view=sql-server-ver15)

### transaction_log metrics
Expand Down Expand Up @@ -344,13 +346,13 @@ An example event for `performance` looks as following:

```json
{
"@timestamp": "2022-06-08T13:35:05.558Z",
"@timestamp": "2022-11-04T12:33:59.171Z",
"agent": {
"ephemeral_id": "16ad2de8-8ba3-496f-98d1-cbe19441c168",
"id": "848cea0e-c052-49b3-983d-64e13d3b9a6f",
"ephemeral_id": "54815e19-bc14-40d2-b1e0-c16234963b52",
"id": "bd4366c7-33ba-4d56-8c63-fc6a15c98c17",
"name": "docker-fleet-agent",
"type": "metricbeat",
"version": "8.3.0"
"version": "8.5.0"
},
"cloud": {
"account": {},
Expand All @@ -376,36 +378,37 @@ An example event for `performance` looks as following:
"version": "8.0.0"
},
"elastic_agent": {
"id": "848cea0e-c052-49b3-983d-64e13d3b9a6f",
"snapshot": true,
"version": "8.3.0"
"id": "bd4366c7-33ba-4d56-8c63-fc6a15c98c17",
"snapshot": false,
"version": "8.5.0"
},
"event": {
"agent_id_status": "verified",
"dataset": "microsoft_sqlserver.performance",
"duration": 7151724,
"ingested": "2022-06-08T13:35:06Z",
"duration": 42729100,
"ingested": "2022-11-04T12:34:00Z",
"module": "sql"
},
"host": {
"architecture": "x86_64",
"containerized": true,
"containerized": false,
"hostname": "docker-fleet-agent",
"id": "66392b0697b84641af8006d87aeb89f1",
"ip": [
"172.18.0.4"
"172.18.0.7"
],
"mac": [
"02:42:ac:12:00:04"
"02-42-AC-12-00-07"
],
"name": "docker-fleet-agent",
"os": {
"codename": "focal",
"family": "debian",
"kernel": "5.10.16.3-microsoft-standard-WSL2",
"kernel": "5.10.104-linuxkit",
"name": "Ubuntu",
"platform": "ubuntu",
"type": "linux",
"version": "20.04.4 LTS (Focal Fossa)"
"version": "20.04.5 LTS (Focal Fossa)"
}
},
"metricset": {
Expand All @@ -414,11 +417,29 @@ An example event for `performance` looks as following:
},
"mssql": {
"metrics": {
"active_temp_tables": 0,
"batch_requests_per_sec": 59,
"buffer_cache_hit_ratio": 990,
"buffer_checkpoint_pages_per_sec": 105,
"buffer_database_pages": 2215,
"buffer_page_life_expectancy": 18,
"buffer_target_pages": 2408448,
"compilations_per_sec": 81,
"dynamic_counter": {
"name": "Memory Grants Pending ",
"value": 0
},
"lock_waits_per_sec": 6,
"logins_per_sec": 18,
"logouts_per_sec": 17,
"page_splits_per_sec": 9,
"re_compilations_per_sec": 0,
"transactions": 0,
"user_connections": 1
}
},
"service": {
"address": "elastic-package-service-microsoft_sqlserver-1:1433",
"address": "elastic-package-service_microsoft_sqlserver_1",
"type": "sql"
}
}
Expand Down