[Enhancement] [Tenable SC] Make enhancement in connector with best practices implementation - #4573
Merged
Merged
Conversation
…r to the convert and date processors
vinit-chauhan
added
enhancement
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset |
2645.5 | 2207.51 | -437.99 (-16.56%) | 💔 |
plugin |
3184.71 | 2262.44 | -922.27 (-28.96%) | 💔 |
vulnerability |
1886.79 | 1366.12 | -520.67 (-27.6%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
P1llus
reviewed
Nov 8, 2022
| @@ -1,50 +1,55 @@ | |||
| # newer versions go on top | |||
| - version: "1.5.0" | |||
| - version: '1.5.1' | |||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/4285 | ||
| - version: "1.4.1" | ||
| - version: '1.4.1' |
| value: '{{{json.macAddress}}}' | ||
| allow_duplicates: false | ||
| - rename: | ||
| ignore_failure: true |
Member
There was a problem hiding this comment.
Please remove ignore_failure in ingest pipeline
| title: Tenable.sc | ||
| # The version must be updated in the pipeline as well. Until elastic/kibana#121310 is implemented we will have to manually sync these. | ||
| version: "1.5.0" | ||
| version: '1.5.1' |
P1llus
approved these changes
Nov 18, 2022
4 tasks
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…actices implementation (elastic#4573) * Update Aggregation visualizations to Lens, Add an on_failure processor to the convert and date processors * Update changelog entry * change as per the review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Make enhancement in Tenable SC connector with listed best practices.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Screenshots