Skip to content

Tenable: additional pipeline sanity checks - #4679

Merged
kgeller merged 4 commits into
elastic:mainfrom
kgeller:tenable-pipeline-fixes
Nov 21, 2022
Merged

Tenable: additional pipeline sanity checks#4679
kgeller merged 4 commits into
elastic:mainfrom
kgeller:tenable-pipeline-fixes

Conversation

@kgeller

@kgeller kgeller commented Nov 18, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Adding a couple missing sanity checks to the pipeline to address an SDH ( thank you again @efd6 )

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

This PR + #4573 should address the following SDH

Relates https://github.com/elastic/sdh-beats/issues/2759

@kgeller kgeller added the bug Something isn't working, use only for issues label Nov 18, 2022
@kgeller kgeller self-assigned this Nov 18, 2022
@kgeller kgeller added the Integration:tenable_sc Tenable Security Center label Nov 18, 2022
@elasticmachine

elasticmachine commented Nov 18, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-21T13:44:01.470+0000

  • Duration: 15 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Nov 18, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 2.31
Classes 100.0% (3/3) 💚 2.31
Methods 100.0% (44/44) 💚 8.815
Lines 96.959% (1116/1151) 👍 5.254
Conditionals 100.0% (0/0) 💚
@kgeller
kgeller marked this pull request as ready for review November 18, 2022 21:25
@kgeller
kgeller requested a review from a team as a code owner November 18, 2022 21:25

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the testcase for this?

{"error_code":0,"error_msg":","response":{"endOffset":"1000","matchingDataElementCount":"0:0:0:0:0:0:0","results":[],"returnedRecords":0,"startOffset":"0","totalRecords":"0"},"timestamp":1257894000,"type":"regular","warnings":[]}
@kgeller
kgeller merged commit c82919e into elastic:main Nov 21, 2022
@kgeller
kgeller deleted the tenable-pipeline-fixes branch November 21, 2022 20:41
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:tenable_sc Tenable Security Center

3 participants