Skip to content

Add Thycotic Secret Server integration #4834 - #4835

Closed
colin-stubbs wants to merge 11 commits into
elastic:mainfrom
colin-stubbs:main
Closed

Add Thycotic Secret Server integration #4834#4835
colin-stubbs wants to merge 11 commits into
elastic:mainfrom
colin-stubbs:main

Conversation

@colin-stubbs

Copy link
Copy Markdown
Contributor

thycotic_ss.logs initial commit

Refer to Add Thycotic Secret Server integration #4834

What does this PR do?

PR addressing Add Thycotic Secret Server integration #4834

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Linting/Testing/etc

How to test this PR locally

A larger sample of logs is available at: thycotic_ss/_dev/deploy/docker/sample_logs/full-sample.log

That can be ingested as a log file by the integration.

Related issues

Screenshots

Integration Configuration

Dashboard

thycotic_ss.logs initial commit
@elasticmachine

elasticmachine commented Dec 15, 2022

Copy link
Copy Markdown

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-13T05:55:48.357+0000

  • Duration: 3 min 53 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/integrations.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/colin-stubbs return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/colin-stubbs : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/colin-stubbs : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Fix event example and field reference
@efd6

efd6 commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

/test

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Are you able to run elastic-package system -g to generated the sample event for the docs and then elastic-package build after moving the README.md fild as suggested.

Comment thread packages/thycotic_ss/LICENSE.txt
Comment thread packages/thycotic_ss/data_stream/logs/_dev/test/pipeline/test-common-config.yml Outdated
Comment thread packages/thycotic_ss/data_stream/logs/agent/stream/log.yml.hbs Outdated
Comment thread packages/thycotic_ss/data_stream/logs/agent/stream/log.yml.hbs
Comment thread packages/thycotic_ss/docs/README.md
Comment thread packages/thycotic_ss/docs/README.md Outdated
Comment thread packages/thycotic_ss/docs/README.md Outdated
Comment thread packages/thycotic_ss/docs/README.md
Comment thread packages/thycotic_ss/manifest.yml Outdated
@colin-stubbs

Copy link
Copy Markdown
Contributor Author

/test

@efd6

efd6 commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

/test

@colin-stubbs

Copy link
Copy Markdown
Contributor Author

Made a mess working on wrong copy/fork, seems like I'll have to redo this properly as it's own fork elsewhere. Will resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants