Skip to content

[Thycotic Secret Server] New integration - #4993

Merged
efd6 merged 3 commits into
elastic:mainfrom
routedlogic:thycotic_ss
Jan 22, 2023
Merged

[Thycotic Secret Server] New integration#4993
efd6 merged 3 commits into
elastic:mainfrom
routedlogic:thycotic_ss

Conversation

@colin-stubbs

Copy link
Copy Markdown
Contributor

Add initial thycotic_ss release

Refer to Add Thycotic Secret Server integration #4834

What does this PR do?

PR addressing Add Thycotic Secret Server integration #4834

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Linting/Testing/etc

How to test this PR locally

A larger sample of logs is available at: thycotic_ss/_dev/deploy/docker/sample_logs/full-sample.log

That can be ingested as a log file by the integration.

Related issues

Screenshots

Configuration

Dashboard

@colin-stubbs colin-stubbs changed the title Add initial thycotic_ss release Jan 13, 2023
@elasticmachine

elasticmachine commented Jan 13, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-20T07:09:22.280+0000

  • Duration: 16 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jamiehynds
jamiehynds requested a review from a team January 16, 2023 11:12
@jamiehynds jamiehynds added Team:Security-External Integrations New Integration Issue or pull request for creating a new integration package. labels Jan 16, 2023
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6

efd6 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Follows from #4835

@efd6

efd6 commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

Build error from logs:

[2023-01-16T21:10:24.614Z] Error: error running package system tests: could not complete test run: could not add data stream config to policy: could not add package to policy; API status code = 422; response body = {"statusCode":422,"error":"Unprocessable Entity","message":"Document \"thycotic_ss-0cb71ae0-5bdd-11ed-b6ae-6bb0097dca82\" has property \"dashboard\" which belongs to a more recent version of Kibana [8.5.0]. The last known version is [8.4.0]"}
@colin-stubbs

Copy link
Copy Markdown
Contributor Author

Build error from logs:

[2023-01-16T21:10:24.614Z] Error: error running package system tests: could not complete test run: could not add data stream config to policy: could not add package to policy; API status code = 422; response body = {"statusCode":422,"error":"Unprocessable Entity","message":"Document \"thycotic_ss-0cb71ae0-5bdd-11ed-b6ae-6bb0097dca82\" has property \"dashboard\" which belongs to a more recent version of Kibana [8.5.0]. The last known version is [8.4.0]"}

Err... does that mean what I think it means? e.g. the automated testing going on behind this repo is still using an older version of elastic-package rather than the most recent release?

@efd6

efd6 commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

The version of elastic package that is being used is v0.70.1 from the go.mod. This error is complaining about the stack version. Please bump the kibana version in the manifest.yml.

@andrewkroh andrewkroh changed the title Resolve #4834 - Add initial thycotic_ss release Jan 18, 2023
@andrewkroh andrewkroh added the Integration:thycotic_ss Thycotic Secret Server (Community supported) label Jan 18, 2023
elastic-package errors because of this for some reason
@colin-stubbs

Copy link
Copy Markdown
Contributor Author

Additional commit made to bump to 8.5.0 after re-run of elastic-package test

@efd6

efd6 commented Jan 20, 2023

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.703
Classes 100.0% (1/1) 💚 2.703
Methods 100.0% (13/13) 💚 9.399
Lines 72.922% (272/373) 👎 -19.778
Conditionals 100.0% (0/0) 💚

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit 5b7a6a5 into elastic:main Jan 22, 2023
@elasticmachine

Copy link
Copy Markdown

Package thycotic_ss - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=thycotic_ss

@colin-stubbs
colin-stubbs deleted the thycotic_ss branch January 28, 2023 02:26
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:thycotic_ss Thycotic Secret Server (Community supported) New Integration Issue or pull request for creating a new integration package.

5 participants