Skip to content

[Azure Metrics] Fix CassandraConnectionClosures metric configuration - #5447

Merged
zmoog merged 2 commits into
mainfrom
zmoog/azure-metrics-database-error
Mar 7, 2023
Merged

[Azure Metrics] Fix CassandraConnectionClosures metric configuration#5447
zmoog merged 2 commits into
mainfrom
zmoog/azure-metrics-database-error

Conversation

@zmoog

@zmoog zmoog commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Move the CassandraConnectionClosures metric name from the always-available list of metrics to the Cassandra-focused list of metrics.

Metric names that are not always available should be listed in a section marked with the ignore_unsupported setting set to true.

The integration works if the subscription has at least one Cassandra cluster available but fails otherwise.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.
@zmoog zmoog self-assigned this Mar 6, 2023
@zmoog zmoog added Team:Cloud-Monitoring Label for the Cloud Monitoring team bug Something isn't working, use only for issues labels Mar 6, 2023
@zmoog zmoog changed the title Move CassandraConnectionClosures metrics Mar 6, 2023
@elasticmachine

elasticmachine commented Mar 6, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T21:44:37.176+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Mar 6, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 73.333% (22/30) 👍 48.333
Lines 100.0% (21/21) 💚
Conditionals 100.0% (0/0) 💚
@zmoog zmoog changed the title [Azure Metrics] Move CassandraConnectionClosures metric name to the right section Mar 6, 2023
@zmoog
zmoog marked this pull request as ready for review March 6, 2023 21:57
@zmoog
zmoog requested a review from a team as a code owner March 6, 2023 21:57
@zmoog
zmoog merged commit 6764a71 into main Mar 7, 2023
@zmoog
zmoog deleted the zmoog/azure-metrics-database-error branch March 7, 2023 11:10
@elasticmachine

Copy link
Copy Markdown

Package azure_metrics - 1.0.14 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
…lastic#5447)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
…lastic#5447)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…lastic#5447)

* Move CassandraConnectionClosures metrics

The name of the metric, "CassandraConnectionClosures" is listed in the
wrong section of the metrics configuration.

It should be moved to a different section that includes metric names
which may or may not be available depending on the environment, with
the "ignore_unsupported" setting set to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants