[Azure Monitor] Fix dimensions for CassandraConnectionClosures - #5465
Merged
Conversation
🌐 Coverage report
|
zmoog
force-pushed
the
zmoog/azure-metrics-cassandra
branch
from
March 8, 2023 14:57
200cd64 to
fce4846
Compare
zmoog
marked this pull request as ready for review
March 8, 2023 15:20
endorama
approved these changes
Mar 8, 2023
|
Package azure_metrics - 1.0.15 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
…ic#5465) * Fix dimensions for CassandraConnectionClosures
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
…ic#5465) * Fix dimensions for CassandraConnectionClosures
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…ic#5465) * Fix dimensions for CassandraConnectionClosures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the
CassandraConnectionClosuresmetric into a dedicated query section using the supported dimensionClosureReasoninstead of the unsupportedDatabaseName.Why is this important?
We must remediate an error introduced in the previous PR when we put the
CassandraConnectionClosuresmetric name together with other Cassandra-related metrics using theDatabaseNamedimension.This can work under some circumstances — that's why we didn't spot the problem!
Unfortunately, this can cause an error since the
CassandraConnectionClosuressupports only theClosureReasonandRegiondimensions.Checklist
changelog.ymlfile.Related issues