[Kubernetes][Dashboard] Fix proxy, controller manager and scheduler dashboards to support TSDB by constanca-m · Pull Request #5992 · elastic/integrations

constanca-m · 2023-04-25T14:57:40Z

What does this PR do?

In proxy, controller manager and scheduler dashboards, there are some visualizations that use counter fields with now unsupported formulas - sum and last_value - when TSDB is enabled. This PR fixes those issues so we can have similar visualizations for the same metrics.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone this branch and run elastic-package build inside Kubernetes package.
Run elastic-package stack up -v -d --version=8.8.0-SNAPSHOT.
Add Kubernetes integration with TSDB enabled for these 3 data streams.

Related issues

Relates to Validate Kubernetes Integration with TSDB #4618

Screenshots

These screenshots only include the before/after of the broken visualizations. Others that used a counter with last_value were switched to max, but there was no change in the visualization. This is needed because last_value is also no longer supported for counter fields once TSDB is enabled.

Proxy dashboard

Before:

After:

Note: "No results found" is shown because there are no documents for the applied filter in these two visualizations. There is nothing wrong with them.

Controller manager dashboard

Before:

After:

Note: Since we can no longer use sum we have to breakdown the metrics by the labels. This will likely lead to very confusing visualizations but as of now, there is no workaround.

Scheduler dashboard

Before:

After:

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

elasticmachine · 2023-04-25T15:27:06Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-05-11T17:17:06.749+0000
Duration: 29 min 4 sec

Test stats 🧪

Test	Results
Failed	0
Passed	92
Skipped	0
Total	92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2023-04-25T15:27:17Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 1.961
Classes	100.0% (`0/0`)	💚 1.961
Methods	96.154% (`75/78`)	👍 6.257
Lines	100.0% (`0/0`)	💚 5.711
Conditionals	100.0% (`0/0`)	💚

drewdaemon

No problems from my end!

gizas · 2023-04-26T07:47:33Z

I would suggest to change the labels of "Average Request" to "Max Average Request" .
Just to be on safe side and more precise to what we depict.

In general you can add the Max ref to all visualisations that include it

…11ed-b760-5d1bccb47f56.json Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

constanca-m · 2023-04-26T08:34:45Z

I would suggest to change the labels of "Average Request" to "Max Average Request" . Just to be on safe side and more precise to what we depict.

I think that might be confusing. Since it is a counter this max will be the same as using last value. @gizas

gizas · 2023-04-26T10:55:46Z

@constanca-m I would say the opposite. The last value can be diffrent than the max and can lead to totally diffrent results in the calculation. For eg. last value of cpu can be something low but the max could have been a spike for the given period. So users should understand what they see

constanca-m · 2023-04-26T11:00:33Z

I am not sure I understand. Since kubernetes.proxy.process.cpu.sec is a counter, we know that the last value will always be equal to the max, since it can only increase. So having counter_rate(last_value(kubernetes.proxy.process.cpu.sec)) and counter_rate(last_value(kubernetes.proxy.process.cpu.sec)) (like before) should be the same thing. The reason to change is that last_value is no longer supported for counters @gizas

gizas · 2023-04-26T11:21:06Z

Ah indeed is a counter, was not paying attention. What happens if the counter resets to zero for example?

constanca-m · 2023-04-26T11:29:42Z

That will be a problem @gizas, but I don't see a workaround for that right now.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

…fix-kubernetes-dashboards

tetianakravchenko · 2023-05-11T07:35:46Z

                                                            }
                                                        },
-                                                        "formula": "last_value(kubernetes.proxy.sync.networkprogramming.duration.us.sum)/(pick_max(last_value(kubernetes.proxy.sync.networkprogramming.duration.us.count),1))/1000000",
+                                                        "formula": "max(kubernetes.proxy.sync.networkprogramming.duration.us.sum)/(pick_max(max(kubernetes.proxy.sync.networkprogramming.duration.us.count),1))/1000000",


if last_value is already supported, according to elastic/kibana#156168, why it was changed here last_value -> max?

it is not critical because of this explanation #5992 (comment), trying to understand if there is any other reason

When I pushed the changes, last value was still not available @tetianakravchenko, but that should be the correct aggregation. I will check that now.

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

elasticmachine · 2023-05-12T07:59:37Z

Package kubernetes - 1.37.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

…ashboards to support TSDB (elastic#5992) * Fix proxy dashboard Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Fix controller manager dashboard Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Fix scheduler dashboard Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Fix version Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update packages/kubernetes/kibana/dashboard/kubernetes-bf9389f0-0c14-11ed-b760-5d1bccb47f56.json Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * Switch max to last value. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * fix package version in manifest Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co> Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

constanca-m added 4 commits April 25, 2023 14:20

Fix proxy dashboard

afcf5c1

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

Fix controller manager dashboard

51b129e

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

Fix scheduler dashboard

27326dd

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

Fix version

83261c7

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

constanca-m added enhancement New feature or request Integration:kubernetes Kubernetes labels Apr 25, 2023

constanca-m requested review from a team and tetianakravchenko April 25, 2023 14:57

constanca-m self-assigned this Apr 25, 2023

constanca-m requested a review from a team as a code owner April 25, 2023 14:57

Update changelog

66fa584

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

constanca-m mentioned this pull request Apr 25, 2023

Validate Kubernetes Integration with TSDB #4618

Closed

24 tasks

drewdaemon approved these changes Apr 25, 2023

View reviewed changes

gizas reviewed Apr 26, 2023

View reviewed changes

Comment thread packages/kubernetes/kibana/dashboard/kubernetes-bf9389f0-0c14-11ed-b760-5d1bccb47f56.json Outdated

Update packages/kubernetes/kibana/dashboard/kubernetes-bf9389f0-0c14-…

a387126

…11ed-b760-5d1bccb47f56.json Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

constanca-m and others added 3 commits May 4, 2023 17:04

Switch max to last value.

16458c2

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

Merge remote-tracking branch 'origin/fix-kubernetes-dashboards' into …

2e9f070

…fix-kubernetes-dashboards

Merge branch 'main' into fix-kubernetes-dashboards

1f0139e

tetianakravchenko reviewed May 11, 2023

View reviewed changes

fix package version in manifest

8772a51

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

tetianakravchenko approved these changes May 11, 2023

View reviewed changes

tetianakravchenko mentioned this pull request May 11, 2023

[Kubernetes] Fix Pod dashboard, remove 2 visualisation to migrate to TSDB #6171

Merged

5 tasks

tetianakravchenko mentioned this pull request May 11, 2023

[Kubernetes] Enable tsdb by default #6159

Merged

4 tasks

gizas approved these changes May 12, 2023

View reviewed changes

tetianakravchenko merged commit 993e972 into elastic:main May 12, 2023

constanca-m deleted the fix-kubernetes-dashboards branch May 15, 2023 07:40

constanca-m mentioned this pull request May 15, 2023

[Kubernetes][Dashboards] Fix proxy, controller manager and scheduler incorrect visualizations and add use of last value #6196

Merged

4 tasks

Navigation Menu

Uh oh!

[Kubernetes][Dashboard] Fix proxy, controller manager and scheduler dashboards to support TSDB - #5992

[Kubernetes][Dashboard] Fix proxy, controller manager and scheduler dashboards to support TSDB#5992
tetianakravchenko merged 10 commits into
elastic:mainfrom
constanca-m:fix-kubernetes-dashboards

constanca-m commented Apr 25, 2023 •

edited

Loading

elasticmachine commented Apr 25, 2023 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Apr 25, 2023 •

edited

Loading

drewdaemon left a comment

Uh oh!

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

tetianakravchenko May 11, 2023

tetianakravchenko May 11, 2023

constanca-m May 15, 2023

elasticmachine commented May 12, 2023

Labels

5 participants

Uh oh!

Conversation

constanca-m commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

How to test this PR locally

Related issues

Screenshots

elasticmachine commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

drewdaemon left a comment

Choose a reason for hiding this comment

Uh oh!

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

gizas commented Apr 26, 2023

constanca-m commented Apr 26, 2023

tetianakravchenko May 11, 2023

Choose a reason for hiding this comment

tetianakravchenko May 11, 2023

Choose a reason for hiding this comment

constanca-m May 15, 2023

Choose a reason for hiding this comment

elasticmachine commented May 12, 2023

Labels

5 participants

constanca-m commented Apr 25, 2023 •

edited

Loading

elasticmachine commented Apr 25, 2023 •

edited

Loading

elasticmachine commented Apr 25, 2023 •

edited

Loading