Skip to content

[Kubernetes] Fix Pod dashboard, remove 2 visualisation to migrate to TSDB - #6171

Merged
tetianakravchenko merged 3 commits into
elastic:mainfrom
tetianakravchenko:k8s-dashboards-pod-apiserver
May 15, 2023
Merged

[Kubernetes] Fix Pod dashboard, remove 2 visualisation to migrate to TSDB#6171
tetianakravchenko merged 3 commits into
elastic:mainfrom
tetianakravchenko:k8s-dashboards-pod-apiserver

Conversation

@tetianakravchenko

Copy link
Copy Markdown
Contributor

What does this PR do?

Pod: use last_value instead of average. For counter average is not supported
Api server:

  • remove 2 visualisation, because now when the aggregation was changed sum -> max we need to break it down by multiple fields, but the current limit is 4. Also it is indeed is quite a lot data per one visualisation, we need to rethink current visualisation

TODO:

  • create an issue to readd removed visualisation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

This includes both non-TSDB and TSDB data
Screenshot 2023-05-11 at 20 15 51

Screenshot 2023-05-11 at 20 15 04
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.38.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally should be merged after #5992

@elasticmachine

elasticmachine commented May 11, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-12T07:40:23.136+0000

  • Duration: 28 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 11, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.983
Classes 100.0% (0/0) 💚 2.983
Methods 96.154% (75/78) 👍 4.466
Lines 100.0% (0/0) 💚 7.956
Conditionals 100.0% (0/0) 💚
@ruflin

ruflin commented May 12, 2023

Copy link
Copy Markdown
Contributor

we need to break it down by multiple fields, but the current limit is 4.

Is this a Lens specific limitation? Is this something that should get removed?

@tetianakravchenko
tetianakravchenko requested a review from gizas May 12, 2023 07:42
@tetianakravchenko

Copy link
Copy Markdown
Contributor Author

we need to break it down by multiple fields, but the current limit is 4.
Is this a Lens specific limitation? Is this something that should get removed?

yes, seems to be Lens specific, there is max 4 fields for the Breakdown, then Add field becomes inactive:
Screenshot 2023-05-15 at 09 15 27

I would create a different issue and investigate how/if possible to reorganize those visualisation

@ruflin

ruflin commented May 15, 2023

Copy link
Copy Markdown
Contributor

@tetianakravchenko Can you file a Kibana issue on this one if this needs changing in the future? #6171 (comment)

@tetianakravchenko
tetianakravchenko merged commit ebc49f7 into elastic:main May 15, 2023
@tetianakravchenko
tetianakravchenko deleted the k8s-dashboards-pod-apiserver branch May 15, 2023 10:25
@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.38.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…TSDB (elastic#6171)

* dashboard changes: Pod and API server

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* update PR number

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants