[ProblemChild] Two Detection Rules Querying Invalid Indices - #7521
Closed
MakoWish wants to merge 9 commits into
Closed
[ProblemChild] Two Detection Rules Querying Invalid Indices#7521MakoWish wants to merge 9 commits into
MakoWish wants to merge 9 commits into
Conversation
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
…/github.com/MakoWish/integrations into rule_tuning_problem_child_probability_score
peteharverson
approved these changes
Aug 24, 2023
peteharverson
left a comment
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM - we are down as CODEOWNERS of this package. No specific ML changes here but LGTM to clear the ml-ui approval.
Member
|
Hi, thank you for the PR! |
ajosh0504
suggested changes
Aug 30, 2023
ajosh0504
left a comment
ajosh0504
left a comment
Contributor
There was a problem hiding this comment.
Let's try to keep the pattern as specific as possible, so -* instead of *. LGTM if you can resolve the version and manifest conflicts. Thanks for trying the package out, and for the PRs!
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
5 tasks
Contributor
|
Also, can we consolidate all these bug /broken link fixes into a single PR resulting in a single patch version bump? Thanks! |
Contributor
Author
|
Consolidating into #7618 |
susan-shu-c
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Update docs with new blog link * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Consolidate #7521 and #7577 into #7618 --------- Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* Update docs with new blog link * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Commit changes from code review Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com> * Consolidate elastic#7521 and elastic#7577 into elastic#7618 --------- Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two of the Detection Rules supplied in the ProblemChild Integration look for
logs-endpoint.events.process.*, but that final period is invalid and will not match an Elastic Endpoint index. These indices are named (using default as an example)logs-endpoint.events.process-default, so this should be eitherlogs-endpoint.events.process*orlogs-endpoint.events.process-*.Checklist
How to test this PR locally
Related issues
Screenshots