Skip to content

[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes - #7618

Merged
susan-shu-c merged 11 commits into
elastic:mainfrom
MakoWish:problem_child_documentation_link
Sep 1, 2023
Merged

[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes#7618
susan-shu-c merged 11 commits into
elastic:mainfrom
MakoWish:problem_child_documentation_link

Conversation

@MakoWish

@MakoWish MakoWish commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

This PR updates the blog post link in the ProblemChild integration's docs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish
MakoWish marked this pull request as ready for review August 30, 2023 17:38
@MakoWish
MakoWish requested review from a team as code owners August 30, 2023 17:38
@MakoWish MakoWish changed the title Problem child documentation link Aug 30, 2023
@elasticmachine

elasticmachine commented Aug 30, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T16:32:09.847+0000

  • Duration: 14 min 51 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@susan-shu-c

Copy link
Copy Markdown
Member

/test

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ML

Comment thread packages/problemchild/changelog.yml Outdated
Comment thread packages/problemchild/changelog.yml Outdated
Comment thread packages/problemchild/manifest.yml Outdated
MakoWish and others added 4 commits August 31, 2023 10:17
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajosh0504 does this look good? The rest of these changes are good to me

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!

@ajosh0504 ajosh0504 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks, @MakoWish! 🚀

if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!

@elasticmachine

Copy link
Copy Markdown

Package problemchild - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=problemchild

@MakoWish MakoWish changed the title [ProblemChild] Update Blog Post Link in Docs Sep 1, 2023
@MakoWish
MakoWish deleted the problem_child_documentation_link branch September 1, 2023 15:21
@andrewkroh andrewkroh added the Integration:problemchild Living off the Land Attack Detection label Jul 22, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Update docs with new blog link

* Commit changes from code review

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>

* Commit changes from code review

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>

* Consolidate elastic#7521 and elastic#7577 into elastic#7618

---------

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:problemchild Living off the Land Attack Detection

6 participants