Skip to content

Tolerate suffixes on the OpenCTI instance URL - #8791

Merged
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:ti-opencti-url-tolerance
Dec 28, 2023
Merged

Tolerate suffixes on the OpenCTI instance URL#8791
chrisberkhout merged 2 commits into
elastic:mainfrom
chrisberkhout:ti-opencti-url-tolerance

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Dec 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

Tolerate suffixes on the OpenCTI instance URL (#8791)

Although a base URL such as 'https://demo.opencti.io' is requested in
the integration settings, we will also tolerate URLs with a trailing
forward slash or '/graphql' path.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist
@chrisberkhout
chrisberkhout requested a review from efd6 December 22, 2023 19:32
@chrisberkhout chrisberkhout self-assigned this Dec 22, 2023
@chrisberkhout
chrisberkhout requested a review from a team as a code owner December 22, 2023 19:32
@elasticmachine

elasticmachine commented Dec 22, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Dec 22, 2023

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
kcreddy
kcreddy approved these changes Dec 28, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@chrisberkhout
chrisberkhout merged commit 8ba2032 into elastic:main Dec 28, 2023
@chrisberkhout
chrisberkhout deleted the ti-opencti-url-tolerance branch December 28, 2023 08:37
@elasticmachine

elasticmachine commented Dec 28, 2023

Copy link
Copy Markdown

Package ti_opencti - 0.3.4 containing this change is available at https://epr.elastic.co/search?package=ti_opencti
@efd6 efd6 mentioned this pull request Feb 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:ti_opencti OpenCTI

3 participants

@chrisberkhout @elasticmachine @kcreddy