Skip to content

[ti_opencti] Update for OpenCTI v5.12.24 GraphQL schema change - #9088

Merged
chrisberkhout merged 4 commits into
elastic:mainfrom
chrisberkhout:ti_opencti-update-graphql
Feb 12, 2024
Merged

[ti_opencti] Update for OpenCTI v5.12.24 GraphQL schema change#9088
chrisberkhout merged 4 commits into
elastic:mainfrom
chrisberkhout:ti_opencti-update-graphql

Conversation

@chrisberkhout

@chrisberkhout chrisberkhout commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Proposed commit message

[ti_opencti] Update for OpenCTI v5.12.24 GraphQL schema change (#9088)

There were breaking changes to the GraphQL schema in OpenCTI v5.12.24,
due to a change in sub list loading strategy.

The previous GraphQL query does not work on OpenCTI v5.12.24 (and
presumably later) and the updated query in this change will not work
on earlier versions of OpenCTI.

For more information, please refer to:

- https://github.com/OpenCTI-Platform/opencti/releases/tag/5.12.24
- https://github.com/OpenCTI-Platform/opencti/pull/5721

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run the automated tests

elastic-package build
elastic-package install
elastic-package test -v

Manually test the integration

Manually test the query only

Copy the updated GraphQL query, run it in the demo instance GraphQL Playground, with query variables as follows:

{
  "first": 3,
  "orderBy": "modified",
  "after": null,
  "orderMode":"asc"
}
@chrisberkhout chrisberkhout added breaking change Team:Service-Integrations Label for the Observability Service Integrations team bugfix Pull request that fixes a bug issue labels Feb 7, 2024
@chrisberkhout chrisberkhout self-assigned this Feb 7, 2024
@chrisberkhout
chrisberkhout requested a review from a team as a code owner February 7, 2024 16:10
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested on playground and with a locally installed integration.

Also, thank you for #8791.

Comment thread packages/ti_opencti/_dev/build/docs/README.md Outdated
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-sonarqube

Copy link
Copy Markdown
@chrisberkhout
chrisberkhout merged commit d1cae69 into elastic:main Feb 12, 2024
@chrisberkhout
chrisberkhout deleted the ti_opencti-update-graphql branch February 12, 2024 09:49
@elasticmachine

Copy link
Copy Markdown

Package ti_opencti - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=ti_opencti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change bugfix Pull request that fixes a bug issue Integration:ti_opencti OpenCTI Team:Service-Integrations Label for the Observability Service Integrations team

4 participants