Update dependency on elastic-package

[mtojek]

This PR bumps up dependency on the elastic-package (changes around semantic validation of spec).

[mtojek]

@ycombinator @rw-access I can't figure out which format of security_rule is correct:

In spec:
https://github.com/elastic/package-spec/blob/master/test/packages/good/kibana/security_rule/000047bb-b27a-47ec-8b62-ef1a5d2c9e19.json

In package:
https://github.com/elastic/integrations/blob/master/packages/security_detection_engine/kibana/security_rule/rule-000047bb-b27a-47ec-8b62-ef1a5d2c9e19.json

Please look at the "rule_id" and "id".

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #987 updated

• Start Time: 2021-05-13T19:45:41.145+0000

• Duration: 32 min 32 sec

• Commit: 4914160

Test stats 🧪

Test	Results
Failed	0
Passed	2132
Skipped	3
Total	2135

Trends 🧪

[rw-access]

Oh! I didn't realize spec was validating anything other than JSON so the spec was out of date. The format inside the integration that's structured like a SO is correct.

[mtojek]

Thanks @rw-access for clarifying this. It seems that we need to fix the package-spec.

[ycombinator]

These changes seem unrelated to the security rule naming changes?

[mtojek]

Linting failed. It seems that the spec hasn't been updated.

[mtojek]

Ah, I see. You're referring to the commit name.

[rw-access]

wait this isn't right. I don't understand why this happened

[mtojek]

We have a rule that ID should consistent with filename. Do you prefer to go the other way round, I mean to rename the file?

[rw-access]

The rule ID can't change, it's defined elsewhere. So we could change the filename. That's fine with me.

I don't really understand why it's a hard and fast requirement or why the change is necessary, to be honest.

[mtojek]

It's for readability and clarity purposes. We encountered misnaming in the past, e.g. "access-logs-dashboard.json" which contains "error-logs-overview". This way we simplify navigating through resources.

[mtojek]

Fixed

[rw-access]

Or this change

[mtojek]

Fixed

Thanks @mtojek

[rw-access]

LGTM. thanks for your patience @mtojek

[ycombinator]

LGTM.