Fix security_rule format - #175
Merged
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
rw-access
reviewed
May 13, 2021
| continue | ||
| } | ||
|
|
||
| if ruleID != objectID { |
Contributor
There was a problem hiding this comment.
There's no reason these have to match.
The rule_id is only relevant to the Security solution.
The top level id is the saved object ID. It's possible that in the future we want better named SO ids. But we can loosen up this spec up then if that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the expected format of security rules.
Why is it important?
We need to properly validate IDs.
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues