[Controls] Persist runPastTimeout setting#208611
Merged
Heenawter merged 2 commits intoelastic:mainfrom Jan 29, 2025
Merged
Conversation
Heenawter
added
bug
Heenawter
added
backport:version
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @Heenawter |
Heenawter
added
backport:prev-major
and removed
backport:version
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jan 29, 2025
Contributor
ThomThomson
left a comment
ThomThomson
left a comment
There was a problem hiding this comment.
Changes LGTM! Good to see this fixed.
| await userEvent.click(control.getByTestId('optionsList-control-selection-bark')); | ||
| await waitOneTick(); | ||
| expect(control.getByTestId('optionsList-control-selection-woof')).not.toBeChecked(); | ||
| await waitFor(async () => { |
Contributor
There was a problem hiding this comment.
Good call to switch to waitFor here.
Contributor
|
Starting backport for target branches: 8.16, 8.17, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 29, 2025
Closes elastic#206459 ## Summary This PR ensures that the `runPastTimeout` setting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject for `runPastTimeout$` to the data control's `editorStateManager` when initializing the options list control, which meant that its value could not be set by the options list's `CustomOptionsComponent` - this PR fixes that. **Before** https://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f **After** https://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit da41b8b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 29, 2025
Closes elastic#206459 ## Summary This PR ensures that the `runPastTimeout` setting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject for `runPastTimeout$` to the data control's `editorStateManager` when initializing the options list control, which meant that its value could not be set by the options list's `CustomOptionsComponent` - this PR fixes that. **Before** https://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f **After** https://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit da41b8b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 29, 2025
Closes elastic#206459 ## Summary This PR ensures that the `runPastTimeout` setting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject for `runPastTimeout$` to the data control's `editorStateManager` when initializing the options list control, which meant that its value could not be set by the options list's `CustomOptionsComponent` - this PR fixes that. **Before** https://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f **After** https://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit da41b8b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 29, 2025
#208764) # Backport This will backport the following commits from `main` to `8.17`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-29T14:46:29Z","message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.17`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Feature:Input Control","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Controls","backport:prev-major","project:embeddableRebuild"],"title":"[Controls] Persist `runPastTimeout` setting","number":208611,"url":"https://github.com/elastic/kibana/pull/208611","mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.17`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208611","number":208611,"mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.17`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jan 29, 2025
…#208765) # Backport This will backport the following commits from `main` to `8.x`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-29T14:46:29Z","message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.x`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Feature:Input Control","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Controls","backport:prev-major","project:embeddableRebuild"],"title":"[Controls] Persist `runPastTimeout` setting","number":208611,"url":"https://github.com/elastic/kibana/pull/208611","mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.x`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208611","number":208611,"mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.x`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jan 29, 2025
#208763) # Backport This will backport the following commits from `main` to `8.16`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-29T14:46:29Z","message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.16`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Feature:Input Control","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Controls","backport:prev-major","project:embeddableRebuild"],"title":"[Controls] Persist `runPastTimeout` setting","number":208611,"url":"https://github.com/elastic/kibana/pull/208611","mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.16`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208611","number":208611,"mergeCommit":{"message":"[Controls] Persist `runPastTimeout` setting (#208611)\n\nCloses https://github.com/elastic/kibana/issues/206459\r\n\r\n## Summary\r\n\r\nThis PR ensures that the `runPastTimeout` setting is persisted for\r\noptions list controls and the UI reflects the value of this setting. The\r\nroot cause of this bug is that we weren't sending in the behavior\r\nsubject for `runPastTimeout# Backport This will backport the following commits from `main` to `8.16`: - [[Controls] Persist `runPastTimeout` setting (#208611)](#208611) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT to the data control's `editorStateManager`\r\nwhen initializing the options list control, which meant that its value\r\ncould not be set by the options list's `CustomOptionsComponent` - this\r\nPR fixes that.\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"da41b8be52609ae62b1baad13fcdbc04f5d1b9a9"}}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206459
Summary
This PR ensures that the
runPastTimeoutsetting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject forrunPastTimeout$to the data control'seditorStateManagerwhen initializing the options list control, which meant that its value could not be set by the options list'sCustomOptionsComponent- this PR fixes that.Before
Screen.Recording.2025-01-28.at.5.36.34.PM.mov
After
Screen.Recording.2025-01-28.at.5.38.37.PM.mov
Checklist
release_note:*label is applied per the guidelines