[8.16] [Controls] Persist `runPastTimeout` setting (#208611)#208763
Merged
kibanamachine merged 1 commit intoelastic:8.16from Jan 29, 2025
Merged
[8.16] [Controls] Persist `runPastTimeout` setting (#208611)#208763kibanamachine merged 1 commit intoelastic:8.16from
kibanamachine merged 1 commit intoelastic:8.16from
Conversation
Closes elastic#206459 ## Summary This PR ensures that the `runPastTimeout` setting is persisted for options list controls and the UI reflects the value of this setting. The root cause of this bug is that we weren't sending in the behavior subject for `runPastTimeout$` to the data control's `editorStateManager` when initializing the options list control, which meant that its value could not be set by the options list's `CustomOptionsComponent` - this PR fixes that. **Before** https://github.com/user-attachments/assets/2c9eeab8-67d9-46bc-938e-4d7cb91e435f **After** https://github.com/user-attachments/assets/d06b6ffa-b1e9-4ecd-b732-69bd69a8aee9 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit da41b8b)
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
2 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @Heenawter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation
Questions ?
Please refer to the Backport tool documentation