Upgrade ES client to 9.0.0-alpha.3#208776
Merged
afharo merged 78 commits intoelastic:mainfrom Feb 25, 2025
Merged
Conversation
# Conflicts: # x-pack/solutions/security/packages/data-stream-adapter/src/create_or_update_data_stream.ts # x-pack/solutions/security/packages/index-adapter/src/create_or_update_index.ts
087452c to
640c0fd
Compare
0561aa3 to
8c610c2
Compare
Contributor
|
It looks like this PR modifies one or more |
45691d7 to
f5c6882
Compare
Contributor
|
It looks like this PR modifies one or more |
cesco-f
added a commit
that referenced
this pull request
Jun 17, 2025
This PR closes #209844 . It also fixes a bug introduces in [this PR](#208776) that was preventing the Error details page from loading. **Before**  **After** 
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
to cesco-f/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2025
This PR closes elastic#209844 . It also fixes a bug introduces in [this PR](elastic#208776) that was preventing the Error details page from loading. **Before**  **After**  (cherry picked from commit a584b04)
cesco-f
added a commit
that referenced
this pull request
Jun 17, 2025
…) (#224251) # Backport This will backport the following commits from `main` to `8.19`: - [[Synthetics] Last Successful screenshots match the step (#224220)](#224220) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-06-17T12:57:44Z","message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"[Synthetics] Last Successful screenshots match the step","number":224220,"url":"https://github.com/elastic/kibana/pull/224220","mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224220","number":224220,"mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
cesco-f
added a commit
that referenced
this pull request
Jun 17, 2025
…) (#224250) # Backport This will backport the following commits from `main` to `8.18`: - [[Synthetics] Last Successful screenshots match the step (#224220)](#224220) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-06-17T12:57:44Z","message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"[Synthetics] Last Successful screenshots match the step","number":224220,"url":"https://github.com/elastic/kibana/pull/224220","mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224220","number":224220,"mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
cesco-f
added a commit
that referenced
this pull request
Jun 17, 2025
… (#224252) # Backport This will backport the following commits from `main` to `9.0`: - [[Synthetics] Last Successful screenshots match the step (#224220)](#224220) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-06-17T12:57:44Z","message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"[Synthetics] Last Successful screenshots match the step","number":224220,"url":"https://github.com/elastic/kibana/pull/224220","mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224220","number":224220,"mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
cesco-f
added a commit
that referenced
this pull request
Jun 17, 2025
…) (#224249) # Backport This will backport the following commits from `main` to `8.17`: - [[Synthetics] Last Successful screenshots match the step (#224220)](#224220) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Francesco Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-06-17T12:57:44Z","message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"[Synthetics] Last Successful screenshots match the step","number":224220,"url":"https://github.com/elastic/kibana/pull/224220","mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224220","number":224220,"mergeCommit":{"message":"[Synthetics] Last Successful screenshots match the step (#224220)\n\nThis PR closes #209844 . It also fixes a bug introduces in [this\nPR](#208776) that was preventing\nthe Error details page from loading.\n\n**Before**\n\n\n**After**\n","sha":"a584b044cf9c76c847897eb03b4de7d3426ca0eb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
semd
added a commit
that referenced
this pull request
Jul 23, 2025
## Summary Fixes inspect modal showing empty request json. The inspect modal was only supporting requests with `body`. However, we recently [introduced](#208776) ES requests without body. To reproduce: - Go to _Explore > Network_ - Select to the _Flows_ tab - Inspect the query of the "Source IPs" or "Destination IPs" sections. - Open the _Request_ tab of the inspect modal It also happens in other sections such as the Countries, Hosts, Users.... Before: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 37 32" src="https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e" /> After: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 39 04" src="https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 23, 2025
…ic#228613) ## Summary Fixes inspect modal showing empty request json. The inspect modal was only supporting requests with `body`. However, we recently [introduced](elastic#208776) ES requests without body. To reproduce: - Go to _Explore > Network_ - Select to the _Flows_ tab - Inspect the query of the "Source IPs" or "Destination IPs" sections. - Open the _Request_ tab of the inspect modal It also happens in other sections such as the Countries, Hosts, Users.... Before: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 37 32" src="https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e" /> After: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 39 04" src="https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit c1ac07b)
kibanamachine
added a commit
that referenced
this pull request
Jul 23, 2025
…228613) (#229152) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] Inspect modal support request without body (#228613)](#228613) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2025-07-23T13:50:53Z","message":"[Security Solution] Inspect modal support request without body (#228613)\n\n## Summary\n\nFixes inspect modal showing empty request json.\n\nThe inspect modal was only supporting requests with `body`. However, we\nrecently [introduced](#208776) ES\nrequests without body.\n\nTo reproduce:\n- Go to _Explore > Network_\n- Select to the _Flows_ tab\n- Inspect the query of the \"Source IPs\" or \"Destination IPs\" sections.\n- Open the _Request_ tab of the inspect modal\n\nIt also happens in other sections such as the Countries, Hosts,\nUsers....\n\nBefore:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 37 32\"\nsrc=\"https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e\"\n/>\n\nAfter:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 39 04\"\nsrc=\"https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"c1ac07b446e3c6a1a7eb39dbbe9eef0a08071f19","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat Hunting","backport:version","v9.1.0","v9.2.0"],"title":"[Security Solution] Inspect modal support request without body","number":228613,"url":"https://github.com/elastic/kibana/pull/228613","mergeCommit":{"message":"[Security Solution] Inspect modal support request without body (#228613)\n\n## Summary\n\nFixes inspect modal showing empty request json.\n\nThe inspect modal was only supporting requests with `body`. However, we\nrecently [introduced](#208776) ES\nrequests without body.\n\nTo reproduce:\n- Go to _Explore > Network_\n- Select to the _Flows_ tab\n- Inspect the query of the \"Source IPs\" or \"Destination IPs\" sections.\n- Open the _Request_ tab of the inspect modal\n\nIt also happens in other sections such as the Countries, Hosts,\nUsers....\n\nBefore:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 37 32\"\nsrc=\"https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e\"\n/>\n\nAfter:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 39 04\"\nsrc=\"https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"c1ac07b446e3c6a1a7eb39dbbe9eef0a08071f19"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228613","number":228613,"mergeCommit":{"message":"[Security Solution] Inspect modal support request without body (#228613)\n\n## Summary\n\nFixes inspect modal showing empty request json.\n\nThe inspect modal was only supporting requests with `body`. However, we\nrecently [introduced](#208776) ES\nrequests without body.\n\nTo reproduce:\n- Go to _Explore > Network_\n- Select to the _Flows_ tab\n- Inspect the query of the \"Source IPs\" or \"Destination IPs\" sections.\n- Open the _Request_ tab of the inspect modal\n\nIt also happens in other sections such as the Countries, Hosts,\nUsers....\n\nBefore:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 37 32\"\nsrc=\"https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e\"\n/>\n\nAfter:\n<img width=\"963\" height=\"579\" alt=\"Captura de pantalla 2025-07-21 a les\n15 39 04\"\nsrc=\"https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0\"\n/>\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"c1ac07b446e3c6a1a7eb39dbbe9eef0a08071f19"}}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…ic#228613) ## Summary Fixes inspect modal showing empty request json. The inspect modal was only supporting requests with `body`. However, we recently [introduced](elastic#208776) ES requests without body. To reproduce: - Go to _Explore > Network_ - Select to the _Flows_ tab - Inspect the query of the "Source IPs" or "Destination IPs" sections. - Open the _Request_ tab of the inspect modal It also happens in other sections such as the Countries, Hosts, Users.... Before: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 37 32" src="https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e" /> After: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 39 04" src="https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jul 31, 2025
…ic#228613) ## Summary Fixes inspect modal showing empty request json. The inspect modal was only supporting requests with `body`. However, we recently [introduced](elastic#208776) ES requests without body. To reproduce: - Go to _Explore > Network_ - Select to the _Flows_ tab - Inspect the query of the "Source IPs" or "Destination IPs" sections. - Open the _Request_ tab of the inspect modal It also happens in other sections such as the Countries, Hosts, Users.... Before: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 37 32" src="https://github.com/user-attachments/assets/95271816-b79c-4fcf-b142-40cbf71e6b7e" /> After: <img width="963" height="579" alt="Captura de pantalla 2025-07-21 a les 15 39 04" src="https://github.com/user-attachments/assets/27eb62d9-dd98-42e0-9313-12ab7d3829c0" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Feb 17, 2026
markov00
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes #253545 ## Details In #208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Feb 18, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit 6234793) # Conflicts: # src/platform/plugins/private/vis_types/vega/public/data_model/search_api.test.ts
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Feb 18, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> (cherry picked from commit 6234793) # Conflicts: # src/platform/plugins/private/vis_types/vega/public/data_model/search_api.test.ts
markov00
added a commit
that referenced
this pull request
Feb 18, 2026
…253680) # Backport This will backport the following commits from `main` to `9.3`: - [[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)](#253560) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2026-02-18T08:14:54Z","message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Vega] Fix `data[].url.body.runtime_mappings` param","number":253560,"url":"https://github.com/elastic/kibana/pull/253560","mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/253560","number":253560,"mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}}]}] BACKPORT--> --------- Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
markov00
added a commit
that referenced
this pull request
Feb 18, 2026
…253787) # Backport This will backport the following commits from `main` to `9.2`: - [[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)](#253560) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2026-02-18T08:14:54Z","message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v9.4.0"],"title":"[Vega] Fix `data[].url.body.runtime_mappings` param","number":253560,"url":"https://github.com/elastic/kibana/pull/253560","mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/253560","number":253560,"mergeCommit":{"message":"[Vega] Fix `data[].url.body.runtime_mappings` param (#253560)\n\n## Summary\n\nFixes a breaking change caused by upgrading the elasticsearch js client\nto `9.x` where we started to ignore the\n`data[].url.body.runtime_mappings` in favor of\n`data[].url.runtime_mappings`.\n\nFixes #253545\n\n## Details\n\nIn #208776 when upgrading to the `9.x` ES client, we changed the code to\npoint at the request `params` instead of `params.body`. Specifically\n[here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31).\n\n```diff\n// src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts\n- let runtimeMappings = requestParams.body.runtime_mappings;\n+ let runtimeMappings = requestParams.runtime_mappings;\n```\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n## Release Notes\n\nFixes a bug where `runtime_mappings` where ignored or overridden in a\nVega spec when defined in `data[].url.body`. Note, the `data[].url.body`\nproperty was deprecated in `kibana@v8.0` and properties moved to\n`data[].url`.\n\n---------\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>","sha":"6234793cfc55be88686e28d015a76300b579c29a"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 19, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
## Summary Fixes a breaking change caused by upgrading the elasticsearch js client to `9.x` where we started to ignore the `data[].url.body.runtime_mappings` in favor of `data[].url.runtime_mappings`. Fixes elastic#253545 ## Details In elastic#208776 when upgrading to the `9.x` ES client, we changed the code to point at the request `params` instead of `params.body`. Specifically [here](https://github.com/elastic/kibana/pull/208776/changes#diff-fca94e46395fddbb9ba787d8d4eadd9bb236856081a09e02fdc7a8b4217a2be5R31). ```diff // src/platform/plugins/private/vis_types/vega/public/data_model/search_api.ts - let runtimeMappings = requestParams.body.runtime_mappings; + let runtimeMappings = requestParams.runtime_mappings; ``` ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Notes Fixes a bug where `runtime_mappings` where ignored or overridden in a Vega spec when defined in `data[].url.body`. Note, the `data[].url.body` property was deprecated in `kibana@v8.0` and properties moved to `data[].url`. --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating the ES client to 9.0.
Resolves #116102
What changes?
Breaking change:
bodyhas been removed.Most of the changes are about bringing all the content inside the body as a root attribute to the API params:
const response = await client.search({ index: 'test', - body: { query: { match_all: {} } - } })For this reason, enabling the "Hide whitespace changes" option when reviewing is recommended.
Some exceptions to this rule:
bodyarray withoperationsarray (direct replacement)bodyarray withsettings(direct replacement)bodyarray withsearchesarray (direct replacement)bodywithdocument(direct replacement)bodywithrepository(direct replacement)Because of a known issue in the client (elastic/elasticsearch-js#2584), there's still an escape hatch to send data in the body in case the specific use case requires it via
// @ts-expect-error elasticsearch@9.0.0 https://github.com/elastic/elasticsearch-js/issues/2584, but it shouldn't be abused because we lose types. In this PR we've used it in those scenarios where we reuse the response of a GET as the body of a PUT/POST.Other changes
estypescan be imported from the root of the library asimport type { estypes } from '@elastic/elasticsearch';estypesWithBodyhave been removedrequestTimeout's 30s default has been removed in the client. This PR explicitly adds the setting in all client usages.Identify risks
bodyusage there via// @ts-expect-error elasticsearch@9.0.0 https://github.com/elastic/elasticsearch-js/issues/2584. The next version of the client will address this.